Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #796: Auto generation of AVIF on save #806

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Feb 19, 2024

Description

Fixes #796

Documentation

User documentation

Fix the issue related to the auto-optimization on save while AVIF is being enable.

Technical documentation

When we save the Imagify settings, we get to a callback which will check if the AVIF is enable or not.
If it is, we will start optimizing the images when AVIF is missing in order to generate these AVIF versions of images.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

Observability

  • I handled errors when needed.

@Miraeld Miraeld added priority: high Issues which should be resolved as quickly as possible AVIF Avif branch/feature labels Feb 19, 2024
@Miraeld Miraeld added this to the 2.2 milestone Feb 19, 2024
@Miraeld Miraeld requested a review from a team February 19, 2024 15:21
@Miraeld Miraeld self-assigned this Feb 19, 2024
@Miraeld Miraeld force-pushed the fix/796-auto-generation-on-settings-save branch from 0894c15 to d11fefb Compare February 19, 2024 15:21
@Tabrisrp
Copy link
Contributor

There is some conflicts to fix after the merge of my PR to the main branch

@jeawhanlee
Copy link
Contributor

@Miraeld Could you fix the codacy errors, they are mostly related to phpcs.

classes/Bulk/Bulk.php Outdated Show resolved Hide resolved
@Miraeld Miraeld requested review from Tabrisrp and a team February 21, 2024 14:37
@Miraeld
Copy link
Contributor Author

Miraeld commented Feb 22, 2024

As noted by @Mai-Saad , if we run only this branch, we might get our file deleted.

However, merging this branch with this one fix the issue :)

So this PR requires #807 :)

@Tabrisrp Tabrisrp merged commit 2d98bbc into feature/avif Feb 22, 2024
1 check failed
@Tabrisrp Tabrisrp deleted the fix/796-auto-generation-on-settings-save branch February 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AVIF Avif branch/feature priority: high Issues which should be resolved as quickly as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVIF images arenot automatically generated for existing images after enabling the option
3 participants