Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of media in the bulk optimization #842

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Mar 6, 2024

Description

This PR reverts the bulk optimization method to how it was originally, as the original already managed the next-gen versions correctly.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote self-explanatory code about what it does.
  • I named variables and functions explicitely.
  • I did not introduce unecessary complexity.

@Tabrisrp Tabrisrp requested a review from a team March 6, 2024 16:35
@Tabrisrp Tabrisrp self-assigned this Mar 6, 2024
@Tabrisrp Tabrisrp mentioned this pull request Mar 6, 2024
14 tasks
@piotrbak piotrbak added this to the 2.2.1 milestone Mar 7, 2024
@Mai-Saad Mai-Saad self-requested a review March 11, 2024 06:41
@Mai-Saad
Copy link

@Tabrisrp Thanks for the PR.
Can see the notice 'Hold on ' that images are already optimized also it isnot displayed (like the one here #830)
scenario:
1- activate imagify
2- disable optimize with upload
3- upload some images
4- in bulk optimization click imagify all
Screenshot from 2024-03-11 08-45-52

@Tabrisrp
Copy link
Contributor Author

Thanks there was a missing change, now it's working, just tested it out on my local

Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Working as expected
Uploading testrail-report-582.pdf…

@Mai-Saad Mai-Saad added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit 3989cab Mar 12, 2024
6 of 7 checks passed
@Mai-Saad Mai-Saad deleted the fix/bulk-optimization branch March 12, 2024 10:54
@Tabrisrp Tabrisrp mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants