Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Composer dev-dependencies and fix resulting issues. #256

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

justlevine
Copy link
Contributor

What

This PR updates the Composer dev-dependencies to their latest versions, and fixes the newly exposed PHPCS/PHPStan smells.

Why

Got a bunch of incoming PRs lined up, and want to use accurate tooling.

How

The only production-code change in this PR is fixing the recursive use of Block::get_attribute_type() from static to instance, since it's registered as a private instance method on the class.

@justlevine justlevine requested a review from a team as a code owner July 23, 2024 00:21
Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 09bc377

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/wp-graphql-content-blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@justlevine
Copy link
Contributor Author

For your review @jasonbahl

@theodesp theodesp merged commit 2b947dc into wpengine:main Jul 25, 2024
9 of 10 checks passed
@justlevine justlevine deleted the chore/dev-deps-and-lint branch July 25, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants