Skip to content

Commit

Permalink
test
Browse files Browse the repository at this point in the history
  • Loading branch information
kael-shipman committed Jan 10, 2024
1 parent 1957be4 commit 4658c4b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 5 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,20 @@ jobs:
--changed-files-ignore-pattern="${{ needs.get-deploy-env.outputs.pnpmIgnorePattern }}" \
typecheck
pnpm \
--parallel \
--filter="${{ needs.get-deploy-env.outputs.pnpmFilter }}" \
--changed-files-ignore-pattern="${{ needs.get-deploy-env.outputs.pnpmIgnorePattern }}" \
prettier
pnpm \
--parallel \
--filter="${{ needs.get-deploy-env.outputs.pnpmFilter }}" \
--changed-files-ignore-pattern="${{ needs.get-deploy-env.outputs.pnpmIgnorePattern }}" \
lint
# - name: Run Tests
# run: pnpm test:raw --changedSince=${{ needs.get-deploy-env.outputs.affected-shas-base }}
# run: pnpm test --changedSince=${{ needs.get-deploy-env.outputs.affected-shas-base }}

##
## Pre-Seed Docker Cache
Expand Down
3 changes: 2 additions & 1 deletion deploy/dockerfile.base
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ ARG STORE_DIR=/monorepo/.pnpm-store SERVICE_NAME="NEED SERVICE_NAME BUILD ARG"
# prod dependencies into the target folder.
RUN \
--mount=type=cache,uid=1000,gid=1000,target=${STORE_DIR} \
--mount=type=secret,id=npmrc,required=true,uid=1000,gid=1000,target=/root/.npmrc \
# NOTE: You may want to change this to `required=true` if you do use private npm packages
--mount=type=secret,id=npmrc,required=false,uid=1000,gid=1000,target=/root/.npmrc \
pnpm --filter "./apps/${SERVICE_NAME}" build && \
pnpm --store-dir "${STORE_DIR}" --filter "./apps/${SERVICE_NAME}" --prod deploy "/pruned/${SERVICE_NAME}" && \
# There's a [bug in pnpm](https://github.com/pnpm/pnpm/issues/6269) that we need to compensate for here
Expand Down
8 changes: 5 additions & 3 deletions scripts/check.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
set -e

pnpm typecheck
pnpm prettier
pnpm lint
for what in typecheck prettier lint test; do
if grep -q '"'$what'"' package.json; then
pnpm $what
fi
done

0 comments on commit 4658c4b

Please sign in to comment.