Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for AndroidX.AppCompat AOT/Reflection/Linking errors #775

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

moljac
Copy link
Member

@moljac moljac commented Aug 17, 2023

Does this change any of the generated binding API's?

Yes. Adds 2 classes that were removed by google (replaced with alternatives)

Describe your contribution

  • dummy Addtions classes added to prevent Reflection, Mono.Cecil, AOT - linking errors in general
    • AndroidX.AppCompat.Graphics.Drawable.DrawableContainer
    • AndroidX.AppCompat.Graphics.Drawable.DrawableWrapper
  • classes are marked with Obsolete attribute

Should fix MAUI/Xamarin.Forms issues:

@moljac
Copy link
Member Author

moljac commented Aug 18, 2023

Repro sample showing it fixes AOT/Reflection/Linking error

NOTE: there are issues with the sample, but because it uses older version of MAUI which uses older versions of AndroidX. (Related: #764)

Archive.zip

@moljac moljac merged commit 90fab52 into main Aug 18, 2023
4 checks passed
@moljac moljac deleted the mu-20230817-fix-maui-16074-xf-15668 branch August 18, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants