Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for AndroidX.AppCompat AOT/Reflection/Linking errors #775

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Fix for AndroidX.AppCompat AOT/Reflection/Linking errors #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f86cd4
dummy Addtions classes added to prevent Reflection, Mono.Cecil, AOT -…
moljac Aug 17, 2023
2bbb7f5
bumped Xamarin.AndroidX.AppCompat.AppCompatResources
moljac Aug 18, 2023
ecc3ccb
Update cgmanifest.json
moljac Aug 18, 2023
08bf27c
Update artifact-list-with-versions.md
moljac Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cgmanifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
"groupId": "androidx.appcompat",
"version": "1.6.1",
"nuGetId": "Xamarin.AndroidX.AppCompat.AppCompatResources",
"nuGetVersion": "1.6.1.3"
"nuGetVersion": "1.6.1.4"
}
},
"license": "The Apache Software License, Version 2.0"
Expand Down
2 changes: 1 addition & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"groupId": "androidx.appcompat",
"artifactId": "appcompat-resources",
"version": "1.6.1",
"nugetVersion": "1.6.1.3",
"nugetVersion": "1.6.1.4",
"nugetId": "Xamarin.AndroidX.AppCompat.AppCompatResources",
"dependencyOnly": false
},
Expand Down
2 changes: 1 addition & 1 deletion docs/artifact-list-with-versions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
| 8|androidx.annotation:annotation-experimental |1.3.1 |Xamarin.AndroidX.Annotation.Experimental |1.3.1.1 |
| 9|androidx.annotation:annotation-jvm |1.6.0 |Xamarin.AndroidX.Annotation.Jvm |1.6.0.2 |
| 10|androidx.appcompat:appcompat |1.6.1 |Xamarin.AndroidX.AppCompat |1.6.1.3 |
| 11|androidx.appcompat:appcompat-resources |1.6.1 |Xamarin.AndroidX.AppCompat.AppCompatResources |1.6.1.3 |
| 11|androidx.appcompat:appcompat-resources |1.6.1 |Xamarin.AndroidX.AppCompat.AppCompatResources |1.6.1.4 |
| 12|androidx.arch.core:core-common |2.2.0 |Xamarin.AndroidX.Arch.Core.Common |2.2.0.3 |
| 13|androidx.arch.core:core-runtime |2.2.0 |Xamarin.AndroidX.Arch.Core.Runtime |2.2.0.3 |
| 14|androidx.asynclayoutinflater:asynclayoutinflater |1.0.0 |Xamarin.AndroidX.AsyncLayoutInflater |1.0.0.19 |
Expand Down
17 changes: 17 additions & 0 deletions ...t/appcompat-resources/Additions/AndroidX.AppCompat.Graphics.Drawable.DrawableContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
using System;
using System.Collections.Generic;
using System.Text;

namespace AndroidX.AppCompat.Graphics.Drawable
{
/// <summary>
///
/// </summary>
/// <seealso href="https://github.com/dotnet/maui/issues/16074" />
/// <seealso href="https://github.com/xamarin/Xamarin.Forms/issues/15668" />
/// <seealso href="https://github.com/xamarin/AndroidX/issues/690#issuecomment-1414325720" />
[Obsolete("This class is obsoleted in this android platform. Google replaced DrawableContainer with DrawableContainerCompat")]
public partial class DrawableContainer : DrawableContainerCompat
{
}
}
22 changes: 22 additions & 0 deletions ...pat/appcompat-resources/Additions/AndroidX.AppCompat.Graphics.Drawable.DrawableWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
using Android.Runtime;
using System;
using System.Collections.Generic;
using System.Text;

namespace AndroidX.AppCompat.Graphics.Drawable
{
/// <summary>
///
/// </summary>
/// <seealso href="https://github.com/dotnet/maui/issues/16074" />
/// <seealso href="https://github.com/xamarin/Xamarin.Forms/issues/15668" />
/// <seealso href="https://github.com/xamarin/AndroidX/issues/690#issuecomment-1414325720" />
[Obsolete("This class is obsoleted in this android platform. Google replaced DrawableWrapper with DrawableWrapperCompat")]
public partial class DrawableWrapper : DrawableWrapperCompat
{
public DrawableWrapper(global::Android.Graphics.Drawables.Drawable drawable) : base(drawable)
{

}
}
}
16 changes: 16 additions & 0 deletions source/androidx.appcompat/appcompat-resources/Additions/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Additions

## AOT Reflection issues

* https://github.com/dotnet/maui/issues/16074

Including specific android libraries via nuget causes AOT failures on RELEASE build #16074

* https://github.com/xamarin/Xamarin.Forms/issues/15668

[Bug] Updating Xamarin.AndroidX.AppCompat to 1.6.0 causes ReflectionLoadException #15668

* https://github.com/xamarin/AndroidX/issues/690#issuecomment-1414325720

Mono.Cecil.ResolutionException: Failed to resolve AndroidX.AppCompat.Graphics.Drawable.DrawableWrapper #690