-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msbuild/tests] Use 'dotnet test' for the MSBuild tests. #21263
[msbuild/tests] Use 'dotnet test' for the MSBuild tests. #21263
Conversation
This is another step towards removing Mono. This required a few changes: * Nullability updates in test code. * Explicitly sorted list of strings in a warning message, to make the warning text stable. * Stopped merging system assemblies in the merged tasks assembly. This was necessary for to solve a problem with duplicate types: * The netstandard2.0 version of `System.Reflection.Metadata.dll` contains the `UnconditionalSuppressMessageAttribute` type (internally). * Since we ILMerge the tasks assembly, this type ends up in Xamarin.iOS.Tasks.dll (internally). * The test assembly can't be a net472 assembly, because that means using the netfx/desktop versions of the Microsoft.Build.* assemblies, which don't work on .NET (they check for Mono, but .NET isn't Mono, so the check fails and a PlatformNotSupportedException is thrown). * So I bumped the test assembly to be a net8.0 assembly, but then there's a conflict between the `UnconditionalSuppressMessageAttribute` shipped in .NET vs the one in `Xamarin.iOS.Tasks.dll` (because the test assembly can see the internals of `Xamarin.iOS.Tasks.dll`). * The fix that seems to work is to *not* merge system assemblies in the `Xamarin.iOS.Tasks.dll` assembly. `Xamarin.iOS.Tasks.Windows.dll` already does this, so hopefully there are no problems on Windows, and on macOS our tests doesn't reveal any problems.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
12 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📚 [CI Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 97 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This comment was marked as outdated.
This comment was marked as outdated.
)" This reverts commit 15c1e75. It breaks the Windows tests.
This is another step towards removing Mono. This required a few changes: * Nullability updates in test code. * Explicitly sorted list of strings in a warning message, to make the warning text stable. * Stopped merging system assemblies in the merged tasks assembly. This was necessary for to solve a problem with duplicate types: * The netstandard2.0 version of `System.Reflection.Metadata.dll` contains the `UnconditionalSuppressMessageAttribute` type (internally). * Since we ILMerge the tasks assembly, this type ends up in Xamarin.iOS.Tasks.dll (internally). * The test assembly can't be a net472 assembly, because that means using the netfx/desktop versions of the Microsoft.Build.* assemblies, which don't work on .NET (they check for Mono, but .NET isn't Mono, so the check fails and a PlatformNotSupportedException is thrown). * So I bumped the test assembly to be a net8.0 assembly, but then there's a conflict between the `UnconditionalSuppressMessageAttribute` shipped in .NET vs the one in `Xamarin.iOS.Tasks.dll` (because the test assembly can see the internals of `Xamarin.iOS.Tasks.dll`). * The fix that seems to work is to *not* merge system assemblies in the `Xamarin.iOS.Tasks.dll` assembly. `Xamarin.iOS.Tasks.Windows.dll` already does this, so hopefully there are no problems on Windows, and on macOS our tests doesn't reveal any problems.
)" This reverts commit 15c1e75. It breaks the Windows tests.
This is another step towards removing Mono.
This required a few changes:
System.Reflection.Metadata.dll
containsthe
UnconditionalSuppressMessageAttribute
type (internally).Xamarin.iOS.Tasks.dll (internally).
the netfx/desktop versions of the Microsoft.Build.* assemblies, which
don't work on .NET (they check for Mono, but .NET isn't Mono, so the
check fails and a PlatformNotSupportedException is thrown).
a conflict between the
UnconditionalSuppressMessageAttribute
shippedin .NET vs the one in
Xamarin.iOS.Tasks.dll
(because the test assemblycan see the internals of
Xamarin.iOS.Tasks.dll
).Xamarin.iOS.Tasks.dll
assembly.Xamarin.iOS.Tasks.Windows.dll
already does this, so hopefully there are no problems on Windows, and on
macOS our tests doesn't reveal any problems.