Add domain separation for originator signatures #235
Merged
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 16, 2024
Your org has enabled the Graphite merge queue for merging into mainAdd the label “Queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “Hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
| PAYER_DOMAIN_SEPARATION_LABEL = "payer|" | ||
| JWT_DOMAIN_SEPARATION_LABEL = "jwt|" | ||
| PAYER_DOMAIN_SEPARATION_LABEL = "payer|" | ||
| ORIGINATOR_DOMAIN_SEPARATION_LABEL = "originator|" |
There was a problem hiding this comment.
Same Q about making this shorter!
richardhuaaa
approved these changes
Oct 17, 2024
neekolas
force-pushed
the
10-16-recover_signer_from_client_envelopes
branch
from
1244b3c
to
1e9a07a
Compare
neekolas
force-pushed
the
10-16-add_domain_separation_for_originator_signatures
branch
from
9657d8c
to
5a4631f
Compare
neekolas
force-pushed
the
10-16-recover_signer_from_client_envelopes
branch
from
1e9a07a
to
3a6f2db
Compare
Base automatically changed from
10-16-recover_signer_from_client_envelopes
to
main
October 18, 2024 00:22
neekolas
force-pushed
the
10-16-add_domain_separation_for_originator_signatures
branch
from
5a4631f
to
93719d9
Compare
neekolas
deleted the
10-16-add_domain_separation_for_originator_signatures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.