Add auth token to GRPC requests #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 16, 2024
neekolas
force-pushed
the
10-16-add_auth_token_to_grpc_requests
branch
from
5b223b3
to
a8dc2b7
Compare
neekolas
force-pushed
the
10-16-add_domain_separation_for_originator_signatures
branch
from
9657d8c
to
5a4631f
Compare
neekolas
force-pushed
the
10-16-add_auth_token_to_grpc_requests
branch
from
a8dc2b7
to
3808b1d
Compare
neekolas
force-pushed
the
10-16-add_domain_separation_for_originator_signatures
branch
from
5a4631f
to
93719d9
Compare
Base automatically changed from
10-16-add_domain_separation_for_originator_signatures
to
main
October 18, 2024 00:25
neekolas
force-pushed
the
10-16-add_auth_token_to_grpc_requests
branch
from
3808b1d
to
80fcbb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
AI Generated Summary
Implemented node-to-node authentication using JWT tokens for secure communication between XMTP nodes.
What changed?
AuthInterceptorfor client-side gRPC calls to inject JWT tokens into request headers.TokenFactoryto useuint32for node IDs instead ofint32.Registrantto include aTokenFactory.syncWorkerto use the newAuthInterceptorwhen connecting to other nodes.NODE_AUTHORIZATION_HEADER_NAMEfor the authentication header.How to test?
pkg/interceptors/client/auth_test.gofor specific tests of the authentication system.Why make this change?
This change enhances the security of the XMTP network by implementing node-to-node authentication. It ensures that only authorized nodes can communicate with each other, preventing unauthorized access to sensitive data and operations. This is a crucial step in maintaining the integrity and confidentiality of the XMTP network.