Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relative_require for other timers #130

Merged
merged 5 commits into from
May 27, 2019
Merged

Conversation

ritikesh
Copy link
Contributor

@ritikesh ritikesh commented Mar 28, 2019

Fixes #129

@ritikesh ritikesh changed the title add relative_require for other timers - Fixes #129 add relative_require for other timers Mar 28, 2019
@ritikesh
Copy link
Contributor Author

is there an update on this?

end
alias :open_flag? :open?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for keeping open_flag? around besides not having to rename the open_flag? calls to open??

Copy link
Contributor Author

@ritikesh ritikesh May 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshafer: Since this is a private method, I don't see a reason why we shouldn't. Updated, pls have a look.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. Sorry it took so long for me to get to this, my notification preferences on this repo were removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging! Do you know anybody I can reach out to for this(yammer/yam#54)? This one's been open for a while as well.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshafer Any chances for a new release soon?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritikesh I'll ask around.

@Sija I'll get out another pre this week. I won't have documentation and upgrade guide done this week so it won't be a final release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshafer Doesn't matter as long it's published on RubyGems :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sija 2.0.0.pre2 is on rubygems, let me know if you run into any issues.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshafer Works like a charm, thanks!

@matthewshafer matthewshafer merged commit 0c508f5 into yammer:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninitialized constant Circuitbox::Timer::Null (NameError)
3 participants