Fix libstorage-ng probing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general code looks good, but if you want full list of needed software for now for storage, you can check list used in d-installer - basically starting with btrfstools https://build.opensuse.org/package/view_file/YaST:Head:Containers/d-installer-all/Dockerfile?expand=1 |
|
Regarding the needed tools for storage, I only added the minimal ones for a reasonable probing. If we want a libstorage-ng that is able to perform commit (which currently doesn't work) we will indeed need to add some extra tools. But maybe at that point we want to discuss whether it's better to have a separate container or something like this. So I'm going intentionally step by step here. |
lslezak
approved these changes
Jul 28, 2022
|
✔️ Public Jenkins job #9 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
libstorage-ng probing didn't exactly work because it was not able to recognize it was running in a chroot. For example, the mount points were calculated with the full path from the host system (eg.
/mnt/home).Solution
Set rootprefix for libstorage-ng, so mount points and other aspects are calculated correctly thanks to the changes introduced recently at libstorage-ng like:
Related changes
For probing to work, the container must contain several basic tools. Almost for sure the package
e2fsprogswill be needed since it includes the commandlsattr. But apart from that, thelvm2package is needed if LVM is used in the system,btrfsprogsis needed if there is some Btrfs file-system, and so on.This adds a reasonable set of tools to the container images and is very likely needed for libstorage-ng probing to actually work:
https://build.opensuse.org/request/show/991060
Testing
Tested manually with modules like yast2-bootloader and yast2-kdump and with the Partitioner.