[READY] Take care of start column in multiline diags for detailed diag popups #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4218 +/- ##
=======================================
Coverage 89.70% 89.71%
=======================================
Files 34 34
Lines 4420 4424 +4
=======================================
+ Hits 3965 3969 +4
Misses 455 455 |
bstaletic
force-pushed
the
detailed-diag-popup-part2-electric-boogaloo
branch
3 times, most recently
from
6d07604
to
06aa107
Compare
Previously, we have always used the diagnostics start column of the *starting* line of a multiline diagnostic. This is wrong, as the starting column for a line in the middle of a multiline diagnostic is always 1. Previous patch just happens to work if the start column of the first line of the diagnostic is also 1.
puremourning
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
|
Thanks for sending a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
Previously, we have always used the diagnostics start column of the starting line of a multiline diagnostic. This is wrong, as the starting column for a line in the middle of a multiline diagnostic is always 1.
Previous patch just happens to work if the start column of the first line of the diagnostic is also 1.
Fixes #4196
This change is