New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] Take care of start column in multiline diags for detailed diag popups #4218

Merged

mergify merged 1 commit into ycm-core:master from bstaletic:detailed-diag-popup-part2-electric-boogaloo

Feb 1, 2024

Commits on Jan 31, 2024

Take care of start column in multiline diags for detailed diag popups

Previously, we have always used the diagnostics start column of the
*starting* line of a multiline diagnostic. This is wrong, as the
starting column for a line in the middle of a multiline diagnostic is
always 1.

Previous patch just happens to work if the start column of the first
line of the diagnostic is also 1.

bstaletic committed Jan 31, 2024