Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StorageLoad docs, YDBDOCS-583 #1530

Merged
merged 13 commits into from
Feb 5, 2024

Conversation

serbel324
Copy link
Collaborator

No description provided.

@serbel324 serbel324 requested a review from a team as a code owner February 1, 2024 16:07
@serbel324 serbel324 force-pushed the YDBDOCS-583-storage-load-actor branch from 3a2122d to 3241c76 Compare February 1, 2024 16:09
Copy link

github-actions bot commented Feb 1, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 1, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 2, 2024

✅ Documentation build

Revision built successfully
Revision preview link

ydb/docs/en/core/development/load-actors-storage.md Outdated Show resolved Hide resolved
ydb/docs/en/core/development/load-actors-storage.md Outdated Show resolved Hide resolved
ydb/docs/en/core/development/load-actors-storage.md Outdated Show resolved Hide resolved
ydb/docs/en/core/development/load-actors-storage.md Outdated Show resolved Hide resolved
Comment on lines 28 to 29
| `PutHandleClass` | Class of data writes to the disk subsystem. If the `TabletLog` value is set, the write operation has the highest priority. |
| `GetHandleClass` | Class of data reads from the disk subsystem. If the `FastRead` is set, the read operation is performed with the highest speed possible. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the classes to choose from?

ydb/docs/en/core/development/load-actors-storage.md Outdated Show resolved Hide resolved
| `BlobSizes` | Size of the blobs to write. It is selected randomly for each request from the `Min`-`Max` range. You can set multiple `WriteSizes` ranges, in which case a value from a specific range will be selected based on its `Weight`. |
| `MaxWritesInFlight` | Maximum number of simultaneously processed write requests. If this parameter is not set then the number of simultaneously processed requests is not limited. |
| `MaxWriteBytesInFlight` | Maximum number of total amount of simultaneously processed write requests' data. If this parameter is not set then the total amount of simultaneously processed write requests' data is not limited. |
| `PutHandleClass` | Class of data writes to the disk subsystem. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly to above it is not clear what to do with this class

ydb/docs/en/core/development/load-actors-storage.md Outdated Show resolved Hide resolved
}
}
```
Calculated percentiles will only represent the requests of the main load cycle and won't include write requests sent during the initial data allocation. The graphs in Monitoring should be of interest, for example, they allow to trace the request latency degradation caused by the increasing load.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Monitoring" probably needs to be a link to some instructions on where to look at

Copy link

github-actions bot commented Feb 2, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 2, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 2, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 5, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 5, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov merged commit e9b6136 into ydb-platform:main Feb 5, 2024
2 checks passed
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants