Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQL-17725 docs for unicode literals #1547

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Feb 2, 2024

  • Documentation

@vitstn vitstn requested review from a team as code owners February 2, 2024 11:09
Copy link

github-actions bot commented Feb 2, 2024

2024-02-02 11:12:12 UTC Pre-commit check for 793f33e has started.
2024-02-02 11:12:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-02 11:14:41 UTC Build successful.
2024-02-02 11:14:57 UTC Tests are running...
🔴 2024-02-02 11:41:54 UTC Test run completed, no test results found for commit f5f22a8. Please check build logs.
2024-02-02 11:41:59 UTC Check cancelled

Copy link

github-actions bot commented Feb 2, 2024

2024-02-02 11:12:17 UTC Pre-commit check for 793f33e has started.
2024-02-02 11:12:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-02 11:14:48 UTC Build successful.
2024-02-02 11:15:01 UTC Tests are running...
🔴 2024-02-02 11:41:55 UTC Test run completed, no test results found for commit f5f22a8. Please check build logs.
2024-02-02 11:41:58 UTC Check cancelled

Copy link

github-actions bot commented Feb 2, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 2, 2024
@@ -169,9 +169,10 @@ SELECT $text;

### Типизированные строковые литералы {#typed-string-literals}

* Для строкового литерала, включая [многострочный](#multiline-string-literals), по умолчанию используется тип `String`.
* Для строкового литерала, включая [многострочный](#multiline-string-literals), по умолчанию используется тип `String` (см. также [PRAGMA UnicodeLiterals](../pragma.md#UnicodeLiterals))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Для строкового литерала, включая [многострочный](#multiline-string-literals), по умолчанию используется тип `String` (см. также [PRAGMA UnicodeLiterals](../pragma.md#UnicodeLiterals))
* Для строкового литерала, включая [многострочный](#multiline-string-literals), по умолчанию используется тип `String` (см. также [PRAGMA UnicodeLiterals](../pragma.md#UnicodeLiterals)).

Copy link

github-actions bot commented Feb 2, 2024

2024-02-02 11:43:55 UTC Pre-commit check for 2f14422 has started.
2024-02-02 11:43:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-02 11:45:04 UTC Build successful.
2024-02-02 11:45:19 UTC Tests are running...
🔴 2024-02-02 13:23:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58852 49542 0 4 9263 43

Copy link

github-actions bot commented Feb 2, 2024

2024-02-02 11:45:08 UTC Pre-commit check for 2f14422 has started.
2024-02-02 11:45:09 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-02 11:46:08 UTC Build successful.
2024-02-02 11:46:17 UTC Tests are running...
🔴 2024-02-02 13:20:47 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14525 14396 0 37 60 32

Copy link

github-actions bot commented Feb 2, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 2, 2024

2024-02-02 13:53:58 UTC Pre-commit check for a128b67 has started.
2024-02-02 13:54:01 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-02 13:55:06 UTC Build successful.
2024-02-02 13:55:17 UTC Tests are running...
🔴 2024-02-02 15:25:28 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14529 14393 0 36 55 45

Copy link

github-actions bot commented Feb 2, 2024

2024-02-02 13:53:59 UTC Pre-commit check for a128b67 has started.
2024-02-02 13:54:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-02 13:55:07 UTC Build successful.
2024-02-02 13:55:18 UTC Tests are running...
🔴 2024-02-02 15:23:27 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58858 49568 0 1 9263 26

Copy link

github-actions bot commented Feb 2, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@vitstn vitstn merged commit d1edd18 into ydb-platform:main Feb 2, 2024
3 of 5 checks passed
Copy link
Member

@fomichev3000 fomichev3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants