Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

niksaveliev · 2024-07-01T09:40:24Z

Changelog entry

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-07-01T09:58:09Z

⚪ 2024-07-01 09:58:09 UTC Pre-commit check for 3b30cac has started.
⚪ 2024-07-01 10:01:37 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-01 10:43:37 UTC Build successful.

github-actions · 2024-07-01T10:41:34Z

⚪ 2024-07-01 10:41:33 UTC Pre-commit check for 3b30cac has started.
⚪ 2024-07-01 10:44:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-01 11:35:28 UTC Build successful.
⚪ 2024-07-01 11:35:43 UTC Tests are running...
🔴 2024-07-01 13:49:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15583	14952	0	107	352	172

🟢 2024-07-01 13:50:33 UTC ydbd size 5.4 GiB changed* by +54.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `ddf20da`	merge: `3b30cac`	diff	diff %
ydbd size	5 831 012 760 Bytes	5 831 068 296 Bytes	+54.2 KiB	+0.001%
ydbd stripped size	1 251 038 056 Bytes	1 251 045 896 Bytes	+7.7 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-01T11:15:15Z

⚪ 2024-07-01 11:15:15 UTC Pre-commit check for 3b30cac has started.
⚪ 2024-07-01 11:18:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-01 12:26:09 UTC Build successful.
⚪ 2024-07-01 12:26:22 UTC Tests are running...
🔴 2024-07-01 14:59:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
76528	63134	0	3	13379	12

🟢 2024-07-01 14:59:46 UTC ydbd size 8.3 GiB changed* by +35.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `ddf20da`	merge: `3b30cac`	diff	diff %
ydbd size	8 953 008 608 Bytes	8 953 045 080 Bytes	+35.6 KiB	+0.000%
ydbd stripped size	488 238 568 Bytes	488 239 624 Bytes	+1.0 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

nshestakov · 2024-07-02T07:17:44Z

ydb/core/persqueue/ut/ut_with_sdk/autoscaling_ut.cpp

+                std::sort(childIds.begin(), childIds.end());
+                UNIT_ASSERT_EQUAL(childIds[0], 1);
+                UNIT_ASSERT_EQUAL(childIds[1], 2);
+            }


add a break here

github-actions · 2024-07-02T09:38:20Z

⚪ 2024-07-02 09:38:20 UTC Pre-commit check for 5285086 has started.
⚪ 2024-07-02 09:41:24 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-02 10:24:08 UTC Build successful.

github-actions · 2024-07-02T09:38:35Z

⚪ 2024-07-02 09:38:35 UTC Pre-commit check for 5285086 has started.
⚪ 2024-07-02 09:41:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-02 10:30:51 UTC Build successful.
⚪ 2024-07-02 10:31:07 UTC Tests are running...
🔴 2024-07-02 12:43:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15633	14989	0	123	348	173

🟢 2024-07-02 12:44:19 UTC ydbd size 5.4 GiB changed* by +53.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `8bf9bed`	merge: `5285086`	diff	diff %
ydbd size	5 829 829 424 Bytes	5 829 884 608 Bytes	+53.9 KiB	+0.001%
ydbd stripped size	1 251 537 384 Bytes	1 251 545 160 Bytes	+7.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-02T09:43:24Z

⚪ 2024-07-02 09:43:24 UTC Pre-commit check for 5285086 has started.
⚪ 2024-07-02 09:46:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-02 10:50:18 UTC Build successful.
⚪ 2024-07-02 10:50:34 UTC Tests are running...
🔴 2024-07-02 13:17:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
76607	63207	0	3	13384	13

🟢 2024-07-02 13:18:03 UTC ydbd size 8.3 GiB changed* by +39.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `8bf9bed`	merge: `5285086`	diff	diff %
ydbd size	8 946 683 664 Bytes	8 946 724 392 Bytes	+39.8 KiB	+0.000%
ydbd stripped size	487 864 872 Bytes	487 870 024 Bytes	+5.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

spuchin · 2024-07-02T16:14:20Z

ydb/public/api/protos/ydb_topic.proto

@@ -1087,6 +1087,11 @@ message DescribeTopicResult {

        // Partition location, filled only when include_location in request is true.
        PartitionLocation partition_location = 6;
+
+        // Inclusive left border. Emptiness means -inf.
+        optional bytes from_bound = 7;


А что там внутри bytes?

Строка. Но там могут быть нечитаемые символы, поэтому байты. Границы не человекочитаемы

Ну вот непонятно как этим пользоваться тогда?
Какой формат, если это бинарные данные?
Что тут будет SDK/Describe возвращать?

Дескрайб в SDK возвращает TString. Вот пример https://github.com/ydb-platform/ydb/pull/6118/files#diff-c7baefa581e4001940d02d8510c369295cc6c020f946c62bc1f1fdccdbd37e61R824

Как пользоваться - лексикографически сравнивать. Можно, например, определить, лежит ли твой ключ в границах партиции просто сравнением

github-actions · 2024-07-16T09:47:22Z

⚪ 2024-07-16 09:47:22 UTC Pre-commit check for 8085ec4 has started.
⚪ 2024-07-16 09:51:01 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-16 10:32:18 UTC Build successful.

github-actions · 2024-07-16T09:51:06Z

⚪ 2024-07-16 09:51:06 UTC Pre-commit check for 8085ec4 has started.
⚪ 2024-07-16 09:54:17 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-16 12:37:06 UTC Build successful.
🔴 2024-07-16 12:49:00 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
76425	62968	0	4	13431	22

🟢 2024-07-16 12:49:51 UTC ydbd size 8.0 GiB changed* by +76.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `457b2b4`	merge: `8085ec4`	diff	diff %
ydbd size	8 642 821 000 Bytes	8 642 898 936 Bytes	+76.1 KiB	+0.001%
ydbd stripped size	470 528 448 Bytes	470 533 984 Bytes	+5.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-16T10:00:08Z

⚪ 2024-07-16 10:00:08 UTC Pre-commit check for 8085ec4 has started.
⚪ 2024-07-16 10:03:19 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-16 12:50:07 UTC Build successful.
🔴 2024-07-16 12:53:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15352	14754	0	86	337	175

🟢 2024-07-16 12:54:40 UTC ydbd size 5.2 GiB changed* by +83.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `457b2b4`	merge: `8085ec4`	diff	diff %
ydbd size	5 548 952 816 Bytes	5 549 037 784 Bytes	+83.0 KiB	+0.002%
ydbd stripped size	1 194 957 904 Bytes	1 194 971 216 Bytes	+13.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-20T13:12:19Z

⚪ 2024-07-20 13:12:19 UTC Pre-commit check for 4e13ff9 has started.
⚪ 2024-07-20 13:15:27 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-20 15:49:38 UTC Build successful.
🔴 2024-07-20 15:58:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
76503	63051	0	3	13437	12

🟢 2024-07-20 15:59:04 UTC ydbd size 8.1 GiB changed* by +76.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `1c15550`	merge: `4e13ff9`	diff	diff %
ydbd size	8 656 109 112 Bytes	8 656 187 048 Bytes	+76.1 KiB	+0.001%
ydbd stripped size	471 115 872 Bytes	471 121 408 Bytes	+5.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-20T13:12:46Z

⚪ 2024-07-20 13:12:46 UTC Pre-commit check for 4e13ff9 has started.
⚪ 2024-07-20 13:15:55 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-20 16:01:55 UTC Build successful.
🔴 2024-07-20 16:06:14 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15401	14785	0	102	343	171

🟢 2024-07-20 16:07:11 UTC ydbd size 5.2 GiB changed* by +87.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `1c15550`	merge: `4e13ff9`	diff	diff %
ydbd size	5 555 545 480 Bytes	5 555 634 536 Bytes	+87.0 KiB	+0.002%
ydbd stripped size	1 196 929 488 Bytes	1 196 946 896 Bytes	+17.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-20T13:12:47Z

⚪ 2024-07-20 13:12:47 UTC Pre-commit check for 4e13ff9 has started.
⚪ 2024-07-20 13:15:57 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-20 14:00:57 UTC Build successful.

…onsumer to CLI (ydb-platform#6118)

Add auto partitioning bounds to SDK and important consumer to CLI

1115b5f

github-actions bot added the not-for-changelog label Jul 1, 2024

niksaveliev changed the title ~~Add auto partitioning bounds to SDK and important consumer to CLI~~ Add few auto partitioning fields to describe and SDK. Add important consumer to CLI Jul 1, 2024

niksaveliev marked this pull request as ready for review July 2, 2024 07:13

niksaveliev requested a review from a team as a code owner July 2, 2024 07:13

niksaveliev requested a review from siarheivesialou July 2, 2024 07:13

nshestakov reviewed Jul 2, 2024

View reviewed changes

nshestakov previously approved these changes Jul 2, 2024

View reviewed changes

fix

262817a

niksaveliev dismissed nshestakov’s stale review via 262817a July 2, 2024 09:36

spuchin reviewed Jul 2, 2024

View reviewed changes

move from and to bound to separate message

c2dba4d

fix

7faead1

nshestakov approved these changes Aug 1, 2024

View reviewed changes

niksaveliev merged commit 6d824a4 into ydb-platform:main Aug 1, 2024
8 of 12 checks passed

nshestakov pushed a commit to nshestakov/ydb that referenced this pull request Aug 1, 2024

Add few auto partitioning fields to describe and SDK. Add important c…

2957170

…onsumer to CLI (ydb-platform#6118)

StekPerepolnen mentioned this pull request Aug 8, 2024

tenantinfo handler added DatabaseStorage #7554

Merged

GrigoriyPA mentioned this pull request Aug 8, 2024

YQ revert local grpc peer value #7555

Merged

nshestakov pushed a commit to nshestakov/ydb that referenced this pull request Aug 8, 2024

Add few auto partitioning fields to describe and SDK. Add important c…

78bae53

…onsumer to CLI (ydb-platform#6118)

GrigoriyPA mentioned this pull request Aug 13, 2024

YQ kqprun pass actor system config #7693

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

niksaveliev commented Jul 1, 2024 •

edited

Loading

github-actions bot commented Jul 1, 2024 •

edited

Loading

github-actions bot commented Jul 1, 2024 •

edited

Loading

github-actions bot commented Jul 1, 2024 •

edited

Loading

nshestakov Jul 2, 2024

github-actions bot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

spuchin Jul 2, 2024

niksaveliev Jul 3, 2024 •

edited

Loading

spuchin Jul 3, 2024

niksaveliev Jul 4, 2024

niksaveliev Jul 4, 2024

github-actions bot commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

Conversation

niksaveliev commented Jul 1, 2024 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented Jul 1, 2024 • edited Loading

github-actions bot commented Jul 1, 2024 • edited Loading

github-actions bot commented Jul 1, 2024 • edited Loading

nshestakov Jul 2, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2024 • edited Loading

github-actions bot commented Jul 2, 2024 • edited Loading

github-actions bot commented Jul 2, 2024 • edited Loading

spuchin Jul 2, 2024

Choose a reason for hiding this comment

niksaveliev Jul 3, 2024 • edited Loading

Choose a reason for hiding this comment

spuchin Jul 3, 2024

Choose a reason for hiding this comment

niksaveliev Jul 4, 2024

Choose a reason for hiding this comment

niksaveliev Jul 4, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 16, 2024 • edited Loading

github-actions bot commented Jul 16, 2024 • edited Loading

github-actions bot commented Jul 16, 2024 • edited Loading

github-actions bot commented Jul 20, 2024 • edited Loading

github-actions bot commented Jul 20, 2024 • edited Loading

github-actions bot commented Jul 20, 2024 • edited Loading

niksaveliev commented Jul 1, 2024 •

edited

Loading

github-actions bot commented Jul 1, 2024 •

edited

Loading

github-actions bot commented Jul 1, 2024 •

edited

Loading

github-actions bot commented Jul 1, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

niksaveliev Jul 3, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 16, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 20, 2024 •

edited

Loading