Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct build-a-sample-app and examples #3416

Closed
wants to merge 5 commits into from

Conversation

moyeah
Copy link
Contributor

@moyeah moyeah commented Sep 24, 2023

Description

  • Add body tags
  • Correct examples links

Checklist

  • I have reviewed my own code

@github-actions
Copy link

github-actions bot commented Sep 24, 2023

Visit the preview URL for this PR (updated for commit 6d415b5):

https://yew-rs--pr3416-add-body-html-tags-3zd6u086.web.app

(expires Sun, 01 Oct 2023 18:17:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

* Correct links
* Correct links
@moyeah moyeah changed the title Correct build-a-sample-app Correct build-a-sample-app and examples Sep 24, 2023
@@ -138,4 +139,4 @@ Trunk will rebuild your application if you modify any of its source code files.

You have now successfully set up your Yew development environment, and built your first web application.

Experiment with this application and review the [examples](./examples.mdx) to further your learning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the examples.mdx contains useful information about the example.
So I am not in favour of people to skip this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@futursolo I agree with you.
I didn't remove the:
Experiment with this application and review the [examples](./examples.mdx) to further your learning.
I replace by
Experiment with this application and review the [examples](https://github.com/yewstack/yew/tree/yew-v0.20.0/examples) to further your learning.

@futursolo
Copy link
Member

Thank you for the pull request.

However, I am not in favour of the changes purposed in this pull request for the reason I described above.
So I will close this pull request.

@futursolo futursolo closed this Sep 29, 2023
@moyeah moyeah deleted the add-body-html-tags branch September 29, 2023 14:48
@moyeah
Copy link
Contributor Author

moyeah commented Sep 29, 2023

Thank you for the pull request.

However, I am not in favour of the changes purposed in this pull request for the reason I described above. So I will close this pull request.

@futursolo
Note
In this PR #3416 is also added the missing <body></body> tags in:

  • website/docs/getting-started/build-a-sample-app.mdx
  • website/versioned_docs/version-0.20/getting-started/build-a-sample-app.mdx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants