-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct build-a-sample-app and examples #3416
Conversation
### Description * Add body tags
### Description * Change examples link to https://github.com/yewstack/yew/tree/yew-v0.20.0/examples
### Description * Add body tags * Change examples link to https://github.com/yewstack/yew/tree/master/examples
Visit the preview URL for this PR (updated for commit 6d415b5): https://yew-rs--pr3416-add-body-html-tags-3zd6u086.web.app (expires Sun, 01 Oct 2023 18:17:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
* Correct links
* Correct links
@@ -138,4 +139,4 @@ Trunk will rebuild your application if you modify any of its source code files. | |||
|
|||
You have now successfully set up your Yew development environment, and built your first web application. | |||
|
|||
Experiment with this application and review the [examples](./examples.mdx) to further your learning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the examples.mdx
contains useful information about the example.
So I am not in favour of people to skip this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@futursolo I agree with you.
I didn't remove the:
Experiment with this application and review the [examples](./examples.mdx) to further your learning.
I replace by
Experiment with this application and review the [examples](https://github.com/yewstack/yew/tree/yew-v0.20.0/examples) to further your learning.
Thank you for the pull request. However, I am not in favour of the changes purposed in this pull request for the reason I described above. |
@futursolo
|
Description
Checklist