Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct build-a-sample-app and examples #3416

Closed
wants to merge 5 commits into from
Closed

Correct build-a-sample-app and examples #3416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
afa2ce0
Update build-a-sample-app.mdx
moyeah Sep 24, 2023
1e334cf
Update build-a-sample-app.mdx
moyeah Sep 24, 2023
455a5df
Update build-a-sample-app.mdx
moyeah Sep 24, 2023
0122996
Update examples.mdx
moyeah Sep 24, 2023
6d415b5
Update examples.mdx
moyeah Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion website/docs/getting-started/build-a-sample-app.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ Finally, add an `index.html` file in the root directory of your app.
<meta charset="utf-8" />
<title>Yew App</title>
</head>
<body></body>
</html>
```

Expand All @@ -138,4 +139,4 @@ Trunk will rebuild your application if you modify any of its source code files.

You have now successfully set up your Yew development environment, and built your first web application.

Experiment with this application and review the [examples](./examples.mdx) to further your learning.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the examples.mdx contains useful information about the example.
So I am not in favour of people to skip this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@futursolo I agree with you.
I didn't remove the:
Experiment with this application and review the [examples](./examples.mdx) to further your learning.
I replace by
Experiment with this application and review the [examples](https://github.com/yewstack/yew/tree/yew-v0.20.0/examples) to further your learning.

Experiment with this application and review the [examples](https://github.com/yewstack/yew/tree/master/examples) to further your learning.
2 changes: 1 addition & 1 deletion website/docs/getting-started/examples.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ We also welcome Pull Requests and issues for when they inevitably get neglected
For more details including a list of examples, refer to the [README].

:::note
Most of the examples have a live deployment that can be found at https://examples.yew.rs/<example_name>.
moyeah marked this conversation as resolved.
Show resolved Hide resolved
Most of the examples have a live deployment that can be found at [examples].
Click the shield on their README page in their respective sub-folder to navigate to the live demo.
:::

Expand Down
3 changes: 2 additions & 1 deletion website/versioned_docs/version-0.20/getting-started/build-a-sample-app.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ Finally, add an `index.html` file in the root directory of your app.
<meta charset="utf-8" />
<title>Yew App</title>
</head>
<body></body>
</html>
```

Expand All @@ -137,4 +138,4 @@ Trunk will rebuild your application if you modify any of its source code files.

You have now successfully setup your Yew development environment, and built your first web application.

Experiment with this application and review the [examples](./examples.mdx) to further your learning.
Experiment with this application and review the [examples](https://github.com/yewstack/yew/tree/yew-v0.20.0/examples) to further your learning.
2 changes: 1 addition & 1 deletion website/versioned_docs/version-0.20/getting-started/examples.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ We also welcome Pull Requests and issues for when they inevitably get neglected
For more details including a list of examples, refer to the [README].

:::note
Most of the examples have a live deployment that can be found at https://examples.yew.rs/<example_name>.
Most of the examples have a live deployment that can be found at [examples].
Click the shield on their individual README page in their respective sub-folder to navigate to the live demo.
:::

Expand Down
Loading