Cleanup ImplicitClone related stuff in the examples #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Benchmark - coreYew MasterPull Request |
|
Visit the preview URL for this PR (updated for commit 224e08b): https://yew-rs-api--pr3508-cleanup-implicit-clo-xpmvce0a.web.app (expires Sun, 26 Nov 2023 10:10:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
|
This reverts commit 71bcd09.
cecton
commented
Nov 6, 2023
|
@kirillsemyonkin now I think the benchmark results look good. Not a big improvement but not a lost either except maybe on the "baseline" but that's probably normal. |
cecton
commented
Nov 11, 2023
Comment on lines
-205
to
-218
| impl Clone for Listeners { | ||
| fn clone(&self) -> Self { | ||
| match self { | ||
| Self::None => Self::None, | ||
| Self::Pending(v) => Self::Pending(v.clone()), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Default for Listeners { | ||
| fn default() -> Self { | ||
| Self::None | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't know why we did that manually but it was not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Changes did on the side:
Related to #3453
Checklist