Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ImplicitClone related stuff in the examples #3508

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Cleanup ImplicitClone related stuff in the examples #3508

wants to merge 30 commits into from

Commits on Nov 1, 2023

  1. Use cheap-to-clone types more

    @cecton
    cecton committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    32df544 View commit details
    Browse the repository at this point in the history

  2. Use IArray in NodeSeq & add IntoPropValue for &AttrValue

    @cecton
    cecton committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fe3636d View commit details
    Browse the repository at this point in the history

  3. Add function get_mut() on VChild to make things easier

    @cecton
    cecton committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d0cfdcb View commit details
    Browse the repository at this point in the history

  4. Use AttrValue in timer_functional example

    @cecton
    cecton committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    77b2656 View commit details
    Browse the repository at this point in the history

  5. Allow iterating over ref of ChildrenRenderer

    @cecton
    cecton committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    71bcd09 View commit details
    Browse the repository at this point in the history

  6. Revert "Allow iterating over ref of ChildrenRenderer" 

    This reverts commit 71bcd09.
    @cecton
    cecton committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2401701 View commit details
    Browse the repository at this point in the history

  7. Still allow ref on childrenrenderer but do not use IArray for now 

    Too complicated
    @cecton
    cecton committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    12aa26d View commit details
    Browse the repository at this point in the history

  8. rustfmt nightly

    @cecton
    cecton committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    46e12dc View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. Merge commit 8d2cfde (no conflict)

    @cecton
    cecton committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    ada85f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Revert changes on NodeSeq because I'm not sure it's useful at all

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    863f174 View commit details
    Browse the repository at this point in the history

  2. Improve example, less clone() necessary

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8242f53 View commit details
    Browse the repository at this point in the history

  3. Optimize VList creation from ref ChildrenRenderer

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    fc402b1 View commit details
    Browse the repository at this point in the history

  4. Very unfortunate consequence of recent refactoring on implicit-clone

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a9f9f93 View commit details
    Browse the repository at this point in the history

  5. The Vecs are actually of identical types...

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    21f04ef View commit details
    Browse the repository at this point in the history

  6. Use Rc<Vec<VNode>> in ChildrenRenderer to avoid needless clones

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ba0b64f View commit details
    Browse the repository at this point in the history

  7. Avoid unnecessary allocation

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    3b0eac8 View commit details
    Browse the repository at this point in the history

  8. Fix invalid use of as_ref()

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    13676be View commit details
    Browse the repository at this point in the history

  9. Oh actually it was useful 

    This reverts commit 863f174.
    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    47e9651 View commit details
    Browse the repository at this point in the history

  10. Fix: NodeSeq now requires OUT to implement ImplicitClone

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a80d1d4 View commit details
    Browse the repository at this point in the history

  11. Revert unnecessary change

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ab1e138 View commit details
    Browse the repository at this point in the history

  12. Simplify code, restore original with_children() signature, optimize

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    38d45d9 View commit details
    Browse the repository at this point in the history

  13. clippy

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    aa788c3 View commit details
    Browse the repository at this point in the history

  14. oops

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    bc96cc7 View commit details
    Browse the repository at this point in the history

  15. Less allocations probably

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0a9a3bc View commit details
    Browse the repository at this point in the history

  16. Code duplication

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d7e4acf View commit details
    Browse the repository at this point in the history

  17. Trigger CI

    @cecton
    cecton committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    25f3494 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Upgrade implicit-clone to 0.4.7 and use derive macro when possible

    @cecton
    cecton committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    64c4b63 View commit details
    Browse the repository at this point in the history

  2. Merge commit 1d88934 (no conflict)

    @cecton
    cecton committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    a5e90d0 View commit details
    Browse the repository at this point in the history

  3. Fix bad location for symbol in test

    @cecton
    cecton committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    b9baa29 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Update implicit-clone to 0.4.8

    @cecton
    cecton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    224e08b View commit details
    Browse the repository at this point in the history