Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_backend: Add an "account birthday" parameter to the create_account API. #901

Closed
str4d opened this issue Aug 17, 2023 · 2 comments

Comments

@str4d
Copy link
Contributor

str4d commented Aug 17, 2023

As part of this implementation, the init_blocks_table and init_accounts_table APIs should be removed in favor of initialization using the normal methods of the data access API, add_account and update_chain_tip. By performing these removals, we can then establish the invariant that the blocks table only contains entries for blocks that the wallet has scanned, which will be a useful property.

@str4d
Copy link
Contributor Author

str4d commented Aug 17, 2023

This issue will need to result in an additional error state indicating that the caller needs to first call update_chain_tip so that newly-created accounts can have birthdays assigned to them (as opposed to ScanRequired which indicates the caller needs to call suggest_scan_ranges).

@nuttycom nuttycom changed the title Add create_account API to DAA that enables defining an "account birthday" zcash_client_backend: Add "account birthday" parameter to the create_account API. Aug 24, 2023
@nuttycom nuttycom changed the title zcash_client_backend: Add "account birthday" parameter to the create_account API. zcash_client_backend: Add an "account birthday" parameter to the create_account API. Aug 24, 2023
@nuttycom
Copy link
Contributor

nuttycom commented Sep 5, 2023

Fixed by #907

@nuttycom nuttycom closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants