zcash_client_sqlite: Ensure that target and anchor heights are relative to the chain tip. #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
chain_tip_target_height
branch
from
d3110ae
to
d738088
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
==========================================
- Coverage 70.73% 70.70% -0.04%
==========================================
Files 131 131
Lines 12728 12742 +14
==========================================
+ Hits 9003 9009 +6
- Misses 3725 3733 +8
☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
chain_tip_target_height
branch
2 times, most recently
from
af33c93
to
f7080a5
Compare
nuttycom
force-pushed
the
chain_tip_target_height
branch
2 times, most recently
from
67029d6
to
69b4d55
Compare
…ve to the chain tip. Prior to the scan-before-sync changes, the wallet was able to assume that the maximum scanned block height at the time of the spend was within a few blocks of the chain tip. However, under linear scanning after the spend-before-sync changes this invariant no longer holds, resulting in a situation where in linear sync conditions the wallet could attempt to create transactions with already-past expiry heights. This change separates the notion of "chain tip" from "max scanned height", relying upon the `scan_queue` table to maintain the wallet's view of the consensus chain height and using information from the `blocks` table only in situations where the latest and/or earliest scanned height is required. As part of this change, the `WalletRead` interface is also modified to disambiguate these concepts.
nuttycom
force-pushed
the
chain_tip_target_height
branch
from
69b4d55
to
dee4385
Compare
str4d
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the scan-before-sync changes, the wallet was able to assume that the maximum scanned block height at the time of the spend was within a few blocks of the chain tip. However, under linear scanning after the spend-before-sync changes this invariant no longer holds, resulting in a situation where in linear sync conditions the wallet could attempt to create transactions with already-past expiry heights.
This change separates the notion of "chain tip" from "max scanned height", relying upon the
scan_queuetable to maintain the wallet's view of the consensus chain height and using information from theblockstable only in situations where the latest and/or earliest scanned height is required.As part of this change, the
WalletReadinterface is also modified to disambiguate these concepts.