Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_sqlite: Ensure that target and anchor heights are relative to the chain tip. #896

Merged
merged 1 commit into from
Aug 17, 2023

Commits on Aug 16, 2023

  1. zcash_client_sqlite: Ensure that target and anchor heights are relati…

    …ve to the chain tip.
    
    Prior to the scan-before-sync changes, the wallet was able to assume
    that the maximum scanned block height at the time of the spend was
    within a few blocks of the chain tip. However, under linear scanning
    after the spend-before-sync changes this invariant no longer holds,
    resulting in a situation where in linear sync conditions the wallet
    could attempt to create transactions with already-past expiry heights.
    
    This change separates the notion of "chain tip" from "max scanned
    height", relying upon the `scan_queue` table to maintain the wallet's
    view of the consensus chain height and using information from the
    `blocks` table only in situations where the latest and/or earliest
    scanned height is required.
    
    As part of this change, the `WalletRead` interface is also modified to
    disambiguate these concepts.
    nuttycom committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    dee4385 View commit details
    Browse the repository at this point in the history