Make slash command output streamable #19632
Merged
+1,131
−502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol requires that certain elements can't be null but instead must be skipped. We correctly skip these now.
JSON RPC notification do not have to contain an id. We do not generate or use id's to ensure we don't rely on them being there.
Unlike normal commands which usually always have autocompletion, context server commands often don't. This makes it hard to understand what can be passed, particularly as commands change often and depending on config. We hence show the name of the argument now as a label (arguable all commands could benefit from that).
This commit replaces the existing SlashCommandOutput with a stream based approach. This allows for slash commands to (1) stream results if needed (2) produce multi-turn messages, e.g. asssistant or system messages (3) will allow for intermediate progress updates during slash command execution. The commit does the following * Introduce `SlashOutputEvent` as events that slash commands can emit. * Introduce `SlashCommandResult` as an alias to a boxed stream of events. * Move all commands to the new command result format.
We are updating the way we deal with commands in output text. Since commands can now emit content events one at a time, each event can determine if it should be run. To support this, we now grab a range and run only commands in the ranges of the content that specified to do so.
When a slash command issues multiple `StartMessage` events with the same role we merge them if merge_same_roles is set to true.
…rom slash commands
Co-Authored-By: David <[email protected]>
Co-Authored-By: David <[email protected]>
Co-Authored-By: Marshall <[email protected]>
Co-authored-by: Antonio <[email protected]>
cla-bot
bot
added
the
cla-signed
Co-authored-by: Max <[email protected]> Co-authored-by: Antonio <[email protected]>
Co-authored-by: Max <[email protected]>
maxbrunsfeld
force-pushed
the
streaming-slash-commands
branch
from
701df6b
to
5c10a5a
Compare
Co-Authored-By: Max <[email protected]> Co-Authored-By: Will <[email protected]>
…nding slash commands
…d is running Co-authored-by: Will <[email protected]>
…holder type tag Co-authored-by: Will <[email protected]>
maxbrunsfeld
force-pushed
the
streaming-slash-commands
branch
from
912d388
to
d4eac88
Compare
maxbrunsfeld
reviewed
Nov 7, 2024
| } | ||
|
|
||
| reserved 4; |
There was a problem hiding this comment.
The thought here is that we aren't bothering to make this change fully backward-compatible; if new versions of Zed collaborate with earlier versions of Zed in the assistant panel, the slash commands will just not fully replicate.
We are making sure to prevent decoding errors or type confusion by using new variant numbers for the new slash command messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for streaming output from slash commands
In this PR we are focused primarily on the interface of the
SlashCommandtrait to support streaming the output. We will follow up later with support for extensions and context servers to take advantage of the streaming nature.Release Notes: