Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make slash command output streamable #19632

Merged
merged 60 commits into from
Nov 7, 2024
Merged

Make slash command output streamable #19632

merged 60 commits into from
Nov 7, 2024
+1,131 −502

Commits on Oct 15, 2024

  1. context_servers: Fix protocol serialization 

    The protocol requires that certain elements can't be null but instead
must be skipped. We correctly skip these now.
    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    98fc57e View commit details
    Browse the repository at this point in the history

  2. context_servers: Remove id from notifications 

    JSON RPC notification do not have to contain an id. We do not generate
or use id's to ensure we don't rely on them being there.
    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c330135 View commit details
    Browse the repository at this point in the history

  3. context_servers: Add a method to list resources similarly to list_pro… 

    …mpts
    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8fa202b View commit details
    Browse the repository at this point in the history

  4. context_servers: Pass prompt description as description/menu_text

    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    525c838 View commit details
    Browse the repository at this point in the history

  5. context_servers: Show argument as a label 

    Unlike normal commands which usually always have autocompletion,
context server commands often don't. This makes it hard to understand
what can be passed, particularly as commands change often and
depending on config. We hence show the name of the argument
now as a label (arguable all commands could benefit from that).
    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9426903 View commit details
    Browse the repository at this point in the history

  6. context_servers: Make clippy happy

    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    23e8842 View commit details
    Browse the repository at this point in the history

  7. slash_commands: Introduce stream based slash commands 

    This commit replaces the existing SlashCommandOutput with a stream
based approach. This allows for slash commands to (1) stream results
if needed (2) produce multi-turn messages, e.g. asssistant or system
messages (3) will allow for intermediate progress updates during
slash command execution.

The commit does the following
* Introduce `SlashOutputEvent` as events that slash commands can emit.
* Introduce `SlashCommandResult` as an alias to a boxed stream of events.
* Move all commands to the new command result format.
    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c9c7412 View commit details
    Browse the repository at this point in the history

  8. assistant: Fix style

    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3ded3e4 View commit details
    Browse the repository at this point in the history

  9. assistant: run_commands_in_output -> run_commands_in_ranges 

    We are updating the way we deal with commands in output text.
Since commands can now emit content events one at a time, each event
can determine if it should be run. To support this, we now grab
a range and run only commands in the ranges of the content that
specified to do so.
    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9156c3f View commit details
    Browse the repository at this point in the history

  10. assistant: Fix context tests

    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3b93237 View commit details
    Browse the repository at this point in the history

  11. assistant: Merge roles when merge_same_roles true 

    When a slash command issues multiple `StartMessage` events with the
same role we merge them if merge_same_roles is set to true.
    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d4ea37c View commit details
    Browse the repository at this point in the history

  12. context_servers: Update protocol and return map of SamplingMessages f… 

    …rom slash commands
    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f2e7d02 View commit details
    Browse the repository at this point in the history

  13. assistant: Introduce a content type for slash commands

    @dsp-ant
    dsp-ant committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3b66a6f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. assistant: remove ensure_newline from StartSection

    @dsp-ant
    dsp-ant committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b04ef6a View commit details
    Browse the repository at this point in the history

  2. assistant: Make file_command stream

    @dsp-ant
    dsp-ant committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6884ddb View commit details
    Browse the repository at this point in the history

  3. Don't reparse slash command when inserting a newline at the end of it 

    Co-Authored-By: David <[email protected]>
    @as-cii @dsp-ant
    2 people authored and dsp-ant committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dc80b1b View commit details
    Browse the repository at this point in the history

  4. Always insert a trailing newline after a section ends 

    Co-Authored-By: David <[email protected]>
    @as-cii @dsp-ant
    2 people authored and dsp-ant committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f2873f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Show a block for invoked slash commands that haven't finished yet 

    Co-Authored-By: Marshall <[email protected]>
    @as-cii @maxdeviant
    as-cii and maxdeviant committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    932b333 View commit details
    Browse the repository at this point in the history

  2. Remove TODO 

    Co-authored-by: Antonio <[email protected]>
    @maxdeviant @as-cii
    maxdeviant and as-cii committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    813e106 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pr/19222

    @maxdeviant
    maxdeviant committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    036b060 View commit details
    Browse the repository at this point in the history

  4. Remove image support

    @maxdeviant
    maxdeviant committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e8407f8 View commit details
    Browse the repository at this point in the history

  5. Map extension slash command output to streaming interface

    @maxdeviant
    maxdeviant committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1963c81 View commit details
    Browse the repository at this point in the history

  6. WIP: Make slash commands return a stream of events

    @maxdeviant
    maxdeviant committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    af73caa View commit details
    Browse the repository at this point in the history

  7. Reassemble SlashCommandOutput from events

    @maxdeviant
    maxdeviant committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    df0cf4d View commit details
    Browse the repository at this point in the history

  8. Fix failing randomized test

    @maxdeviant
    maxdeviant committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    320af9c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'streaming-return-type' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ccca8bd View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge branch 'main' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    65d8048 View commit details
    Browse the repository at this point in the history

  2. Remove unused struct

    @maxdeviant
    maxdeviant committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2e182be View commit details
    Browse the repository at this point in the history

  3. Remove some of the diff from main

    @maxdeviant
    maxdeviant committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6642fc5 View commit details
    Browse the repository at this point in the history

  4. Fixed streaming slash command output insertion 

    Co-authored-by: Antonio <[email protected]>
    @maxdeviant @as-cii
    maxdeviant and as-cii committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a8bcb3d View commit details
    Browse the repository at this point in the history

  5. Revert changes to parsing to fix slash command running 

    Co-authored-by: Antonio <[email protected]>
    @maxdeviant @as-cii
    maxdeviant and as-cii committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    24cf9c4 View commit details
    Browse the repository at this point in the history

  6. Pass command information to block renderer 

    Co-authored-by: Antonio <[email protected]>
    @maxdeviant @as-cii
    maxdeviant and as-cii committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    583fbf7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2287f2f View commit details
    Browse the repository at this point in the history

  8. Style invoked slash commands a bit more

    @maxdeviant
    maxdeviant committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    673c3af View commit details
    Browse the repository at this point in the history

  9. Add button to dismiss errors for slash commands

    @maxdeviant
    maxdeviant committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    df50cbe View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'main' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6a3a87a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Merge branch 'main' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6f1eafb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    88a0975 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge branch 'main' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    55dd7d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge branch 'main' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fd4bda0 View commit details
    Browse the repository at this point in the history

  2. Fix error after merge

    @maxdeviant
    maxdeviant committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    25f6a1e View commit details
    Browse the repository at this point in the history

  3. WIP: Begin the switch to creases

    @maxdeviant
    maxdeviant committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2da5290 View commit details
    Browse the repository at this point in the history

  4. WIP: Fix some issues with streaming in content into a crease 

    Co-authored-by: Max <[email protected]>
Co-authored-by: Antonio <[email protected]>
    @maxdeviant @maxbrunsfeld @as-cii
    3 people committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d9a2289 View commit details
    Browse the repository at this point in the history

  5. Remove extra newlines from example streaming command

    @maxdeviant
    maxdeviant committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1406f5f View commit details
    Browse the repository at this point in the history

  6. Leave the slash command text in until the end

    @maxdeviant
    maxdeviant committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8ddffd7 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge branch 'main' into streaming-slash-commands

    @maxdeviant
    maxdeviant committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    382dd5a View commit details
    Browse the repository at this point in the history

  2. WIP: Add collaboration 

    Co-authored-by: Max <[email protected]>
    @maxdeviant @maxbrunsfeld
    maxdeviant and maxbrunsfeld committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5c10a5a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Remove unused arguments parameter, remove noisy log

    @maxbrunsfeld
    maxbrunsfeld committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6efa983 View commit details
    Browse the repository at this point in the history

  2. Add missing slash command update event when applying operation

    @maxbrunsfeld
    maxbrunsfeld committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    2f1c701 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into streaming-slash-commands

    @as-cii
    as-cii committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    00123a6 View commit details
    Browse the repository at this point in the history

  4. Invalidate creases for sections that have been deleted

    @as-cii
    as-cii committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bcf95bb View commit details
    Browse the repository at this point in the history

  5. Restructure test for slash commands

    @as-cii
    as-cii committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8346801 View commit details
    Browse the repository at this point in the history

  6. Make the slash command test pass 

    Co-Authored-By: Max <[email protected]>
Co-Authored-By: Will <[email protected]>
    @as-cii @maxbrunsfeld @wbbradley
    3 people committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a52bc59 View commit details
    Browse the repository at this point in the history

  7. Add APIs for removing folds with specific ranges, fix unfolding of pe… 

    …nding slash commands
    @maxbrunsfeld
    maxbrunsfeld committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    332a679 View commit details
    Browse the repository at this point in the history

  8. Ensure slash command output is contained in pending fold while comman… 

    …d is running

Co-authored-by: Will <[email protected]>
    @maxbrunsfeld @wbbradley
    maxbrunsfeld and wbbradley committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a527613 View commit details
    Browse the repository at this point in the history

  9. On slash command completion, remove pending output folds by its place… 

    …holder type tag

Co-authored-by: Will <[email protected]>
    @maxbrunsfeld @wbbradley
    maxbrunsfeld and wbbradley committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    798568e View commit details
    Browse the repository at this point in the history

  10. Remove unused expand_result parameters and fields

    @maxbrunsfeld
    maxbrunsfeld committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    068d2d4 View commit details
    Browse the repository at this point in the history

  11. Fix clippy warnings

    @maxbrunsfeld
    maxbrunsfeld committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1b6627b View commit details
    Browse the repository at this point in the history

  12. Fix spelling error

    @maxbrunsfeld
    maxbrunsfeld committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d4eac88 View commit details
    Browse the repository at this point in the history

  13. Rename new slash command message to appease protobuf checker

    @maxbrunsfeld
    maxbrunsfeld committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f6eee03 View commit details
    Browse the repository at this point in the history