Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for recent model changes #42

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix for recent model changes #42

merged 1 commit into from
Oct 9, 2024

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Oct 9, 2024

Describe changes

Now Model(...).number fails explicitly if no version can be fetched, while before it was just logging info and returning None.

Pre-requisites

Please ensure you have done the following:

  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have updated ref-zenml in .github/workflows/ci.yml accordingly (if you don't know - main would be a solid choice)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@avishniakov avishniakov requested a review from bcdurak October 9, 2024 15:08
@avishniakov avishniakov merged commit b8f0580 into main Oct 9, 2024
16 checks passed
@avishniakov avishniakov deleted the 2024.10.09 branch October 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants