Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon S3 bucket storage backend. #83

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add support for Amazon S3 bucket storage backend. #83

merged 1 commit into from
Nov 22, 2024

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Nov 17, 2024

This adds support for using Amazon's S3 bucket as a storage backend via the AwsStore module. It is only implemented for the Lwt concurrency library at this time since the underlying AWS-S3 library does not yet have support for Eio.

addresses #55

@zoj613 zoj613 added enhancement New feature or request storage related to storage labels Nov 17, 2024
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 91.57895% with 8 lines in your changes missing coverage. Please review.

Project coverage is 97.64%. Comparing base (722ab04) to head (6adbbaa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zarr-lwt/src/storage.ml 91.57% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   98.03%   97.64%   -0.40%     
==========================================
  Files          16       16              
  Lines        1474     1569      +95     
==========================================
+ Hits         1445     1532      +87     
- Misses         29       37       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zoj613 zoj613 force-pushed the awsstore branch 8 times, most recently from 426f617 to 3861352 Compare November 18, 2024 17:05
@zoj613 zoj613 marked this pull request as ready for review November 18, 2024 17:11
@zoj613 zoj613 force-pushed the awsstore branch 9 times, most recently from f16fc35 to ee2d821 Compare November 19, 2024 08:55
@zoj613 zoj613 linked an issue Nov 19, 2024 that may be closed by this pull request
@zoj613 zoj613 force-pushed the awsstore branch 4 times, most recently from 3241f91 to 93709eb Compare November 20, 2024 21:13
This adds support for using Amazon's S3 bucket as a storage backend via
the `AmazonS3Store` module. It is only implemented for the `Lwt` concurrency
library at this time since the underlying AWS-S3 library does not yet
have support for `Eio`.
@zoj613 zoj613 merged commit 94822ca into main Nov 22, 2024
2 of 4 checks passed
@zoj613 zoj613 deleted the awsstore branch November 22, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request storage related to storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AmazonS3 and Http storage backends
1 participant