Fix bareword in Zonemaster::Engine. #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running Debian Perl Team's syntax checks on Zonemaster::Engine reveals the following issues: # Bareword "Zonemaster::Engine::Recursor::init_recursor" not allowed while "strict subs" in use at /usr/share/perl5/Zonemaster/Engine.pm line 40. # Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Recursor.pm line 15. # BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Recursor.pm line 15. # Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Test/Address.pm line 13. # BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Test/Address.pm line 13. # Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Test/Consistency.pm line 14. # BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Test/Consistency.pm line 14. not ok 17 - /usr/bin/perl -wc /usr/share/perl5/Zonemaster/Engine/Test/Consistency.pm exited successfully […] # Bareword "Zonemaster::Engine::Recursor::init_recursor" not allowed while "strict subs" in use at /usr/share/perl5/Zonemaster/Engine.pm line 40. # Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Recursor.pm line 15. # BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Recursor.pm line 15. # Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Test/Zone.pm line 19. # BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Test/Zone.pm line 19. not ok 20 - /usr/bin/perl -wc /usr/share/perl5/Zonemaster/Engine/Test/Zone.pm exited successfully This seems to be caused by missing parenthesis to trigger the invocation of Zonemaster::Engine::Recursor::init_recursor method. Restoring them looks to fix, or at least works around, the issue. Signed-off-by: Étienne Mollier <[email protected]>
tgreenx
requested review from
mattias-p,
matsduf,
tgreenx,
marc-vanderwal and
MichaelTimbert
tgreenx
added
the
V-Patch
tgreenx
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
LGTM. Thanks for the contribution. Note that I have changed the base branch from master to develop, which is the branch that should be used for this project (see https://github.com/zonemaster/zonemaster/blob/master/README.md#participation).
matsduf
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This request consists in invoking Zonemaster::Engine::Recursor::init_recursor method instead of readying it for futher invocation, as a syntax check flags it as a Bareword.
Context
Running Debian Perl Team's syntax checks on Zonemaster::Engine reveals the following issues:
This seems to be caused by missing parenthesis to trigger the invocation of Zonemaster::Engine::Recursor::init_recursor method.
Changes
Restoring these parenthesis looks to fix, or at least works around, the issue.
How to test this PR
I ran the Debian Perl Team test, which includes routines to invoke the full upstream test suite but also the syntax check, and made sure the issue was resolved.