Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bareword in Zonemaster::Engine. #1380

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix bareword in Zonemaster::Engine. #1380

merged 1 commit into from
Aug 21, 2024

Commits on Aug 8, 2024

  1. Fix bareword in Zonemaster::Engine. 

    Running Debian Perl Team's syntax checks on Zonemaster::Engine reveals
the following issues:

	# Bareword "Zonemaster::Engine::Recursor::init_recursor" not allowed while "strict subs" in use at /usr/share/perl5/Zonemaster/Engine.pm line 40.
	# Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Recursor.pm line 15.
	# BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Recursor.pm line 15.
	# Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Test/Address.pm line 13.
	# BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Test/Address.pm line 13.
	# Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Test/Consistency.pm line 14.
	# BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Test/Consistency.pm line 14.
	not ok 17 - /usr/bin/perl -wc /usr/share/perl5/Zonemaster/Engine/Test/Consistency.pm exited successfully
	[…]
	# Bareword "Zonemaster::Engine::Recursor::init_recursor" not allowed while "strict subs" in use at /usr/share/perl5/Zonemaster/Engine.pm line 40.
	# Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Recursor.pm line 15.
	# BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Recursor.pm line 15.
	# Compilation failed in require at /usr/share/perl5/Zonemaster/Engine/Test/Zone.pm line 19.
	# BEGIN failed--compilation aborted at /usr/share/perl5/Zonemaster/Engine/Test/Zone.pm line 19.
	not ok 20 - /usr/bin/perl -wc /usr/share/perl5/Zonemaster/Engine/Test/Zone.pm exited successfully

This seems to be caused by missing parenthesis to trigger the
invocation of Zonemaster::Engine::Recursor::init_recursor method.
Restoring them looks to fix, or at least works around, the issue.

Signed-off-by: Étienne Mollier <[email protected]>
    @emollier
    emollier committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4330e66 View commit details
    Browse the repository at this point in the history