Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the custom attrs meta to direct_item start requests. #70

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Oct 2, 2024

No description provided.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.63%. Comparing base (9fe01af) to head (95afbef).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
zyte_spider_templates/spiders/ecommerce.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   96.73%   96.63%   -0.10%     
==========================================
  Files          16       16              
  Lines         950      952       +2     
==========================================
+ Hits          919      920       +1     
- Misses         31       32       +1     
Files with missing lines Coverage Δ
zyte_spider_templates/spiders/ecommerce.py 93.38% <50.00%> (-0.73%) ⬇️

@wRAR wRAR merged commit 01c8a70 into main Oct 2, 2024
11 of 12 checks passed
@wRAR wRAR deleted the custom-attrs-direct-item branch October 2, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants