Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the custom attrs meta to direct_item start requests. #70

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Add the custom attrs meta to direct_item start requests. #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions zyte_spider_templates/spiders/ecommerce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,14 @@
else "productNavigation"
},
}
if (
self.args.crawl_strategy == EcommerceCrawlStrategy.direct_item
and self._custom_attrs_dep
):
meta["inject"] = [

Check warning on line 194 in zyte_spider_templates/spiders/ecommerce.py

View check run for this annotation

Codecov / codecov/patch

zyte_spider_templates/spiders/ecommerce.py#L194 

Added line #L194 was not covered by tests
self._custom_attrs_dep,
]

if self.args.crawl_strategy == EcommerceCrawlStrategy.full:
meta["page_params"] = {"full_domain": get_domain(url)}
elif self.args.crawl_strategy == EcommerceCrawlStrategy.automatic:
Expand Down
Loading