Optimise some LongSequence constructors #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, constructors of `LongSequence{<:NucleicAcidAlphabet}` from
`LongSequence` or `LongSubSeq` of `NucleicAcidAlphabet`, where the alphabet
bit size is different.
Simple benchmarks suggests an improvement of 4-7x for long sequences.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 90.87% 90.30% -0.58%
==========================================
Files 31 30 -1
Lines 2400 2527 +127
==========================================
+ Hits 2181 2282 +101
- Misses 219 245 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, constructors of
LongSequence{<:NucleicAcidAlphabet}fromLongSequenceorLongSubSeqofNucleicAcidAlphabet, where the alphabet bit size is different.Simple benchmarks suggests an improvement of 4-7x for long sequences.
This makes nice use of the new internal abstraction from #316 :)