Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support message template and color settings for SlackReporter #95

Merged
merged 12 commits into from
Nov 6, 2024
Merged

Support message template and color settings for SlackReporter #95

merged 12 commits into from
Nov 6, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • Add lead text and message body template settings; can use placeholders
  • Add attachments color settings

Priority

I hope to your review && merge around one week.
There is no need to release it yet.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 3, 2024 22:06
@nowsprinting nowsprinting mentioned this pull request Nov 5, 2024
Closed
10 tasks
bo40
bo40 previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

get-me-power
get-me-power previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@get-me-power
Copy link
Member

get-me-power commented Nov 6, 2024 •
edited
Loading

@nowsprinting
Editor/UI/Settings/AutopilotSettingsEditor.cs is conflicted.
Would you resolve it?

@nowsprinting nowsprinting dismissed stale reviews from get-me-power and bo40 via 1a846a1 November 6, 2024 07:36
@nowsprinting nowsprinting force-pushed the feature/slackreporter_placeholders branch from 57849d4 to 1a846a1 Compare November 6, 2024 07:36
@nowsprinting
Copy link
Contributor Author

@get-me-power san, rebased!

get-me-power
get-me-power approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@get-me-power get-me-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@get-me-power
Copy link
Member

@nowsprinting

Thanks!

@get-me-power get-me-power merged commit 8b4c5dd into DeNA:master Nov 6, 2024
1 check passed
@nowsprinting nowsprinting deleted the feature/slackreporter_placeholders branch November 6, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@get-me-power get-me-power get-me-power approved these changes

@bo40 bo40 bo40 left review comments

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nowsprinting @get-me-power @bo40