Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid glibc versions. #167

Closed
cazador481 opened this issue Mar 18, 2024 · 5 comments · Fixed by #323
Closed

Invalid glibc versions. #167

cazador481 opened this issue Mar 18, 2024 · 5 comments · Fixed by #323
Labels
node issues relating to the fact that basedpyright depends on nodejs (the nodejs-wheel pypi package)

Comments

@cazador481
Copy link

I am getting invalid glibc versions with the build in version of node. I would like to use my own version of node that is installed on my machine.

/home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node)
/home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node: /lib64/libc.so.6: version `GLIBC_2.25' not found (required by /home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node)
/home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node)
/home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node)
/home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node)
/home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/scratch.eash/.pipx/venvs/basedpyright/lib/python3.9/site-packages/nodejs/bin/node)
@DetachHead
Copy link
Owner

what OS are you using?

the point of having the node version bundled with the pypi package is that the user shouldn't have to worry about installing it themselves. i see nodejs as an implementation detail that shouldn't be exposed to the user, so hopefully i can find a solution that doesn't require allowing the user to specify a globally installed node

@cazador481
Copy link
Author

cazador481 commented Mar 18, 2024 via email

@DetachHead DetachHead added the node issues relating to the fact that basedpyright depends on nodejs (the nodejs-wheel pypi package) label Mar 20, 2024
This was referenced Mar 25, 2024
@DetachHead
Copy link
Owner

DetachHead commented Mar 25, 2024

looks like that's the issue. basedpyright comes with node 18 but i think your centOS version is too old for that. https://stackoverflow.com/a/72038045

since both centOS and node 16 are EOL i was originally going to close this issue, but then i realized upstream pyright supports node 14 so i should probably try to match that.

can you install the version from #204 and see if that fixes it?

pip install git+https://github.com/detachhead/basedpyright@support-node14

you may need to pin nodejs-bin to 14.19.3a4 yourself though

@lewis6991
Copy link
Contributor

lewis6991 commented Apr 25, 2024

https://pypi.org/project/nodejs-wheel/ supports a much older glibc version and can confirm it works on rhel7 (similar to centos7). Would it be possible to switch to (or optionally use) that instead?

@DetachHead
Copy link
Owner

thanks for the suggestion, we can give it a go. the one we currently use looks abandoned so i was already keeping an eye out for another solution anyway

lewis6991 added a commit to lewis6991/basedpyright that referenced this issue Apr 25, 2024
DetachHead pushed a commit to lewis6991/basedpyright that referenced this issue Apr 25, 2024
DetachHead pushed a commit to lewis6991/basedpyright that referenced this issue May 8, 2024
DetachHead pushed a commit that referenced this issue May 8, 2024
Wider support for older glibc

Fixes #167
NCBM pushed a commit to sena-nana/basedpyright that referenced this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node issues relating to the fact that basedpyright depends on nodejs (the nodejs-wheel pypi package)
Projects
None yet
3 participants