Localization: added more missing strings/moved to .properties #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved ammo strings from "garrysmod_english.txt" to "entities.properties" (to make pick up notification localizable). - - Some characters' capitalization in those strings was updated (for some reason after moving to .properites they were trying to find different strings). - - Some ammo names were updated to avoid confusion when picking up HL1 ammo similar to HL2, which are actually different. - Added localization support for "Author:" in the spawn menu tooltips (for entities, weapons, vehicles). - Added localization support for "Force:" in the world tooltip for balloons. - Garry's Mod, HL2 and HL1 weapons now use localization from entites.properties in the weapon selector and pickup notification.
NovaDiablox
suggested changes
Dec 2, 2024
Thanks to @NovaDiablox
NovaDiablox
approved these changes
Dec 2, 2024
Moved strings from "\language\npc-ents-english.txt" to "entities.properties". - for example, this will allow the kill feed to get their localized alternatives. - Removed \language\npc-ents-english.txt since now it's empty. Added "npc_tf2_ghost" to "entities.properties": turns out we didn't have it in the past.
Satton2
added a commit
to Satton2/garrysmod
that referenced
this pull request
Dec 4, 2024
This will prevent unnecessary strings to be added after Facepunch#2166 This also fits more since other entities called the same way.
Once again, something went wrong with resolving conflicts last time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Garry's Mod(already done by Rubat here: a413b41), HL2 and HL1 weapons now use localization from entites.properties in the weapon selector and the pickup notifications.Added "npc_tf2_ghost" to "entities.properties": turns out we didn't have it in the past.
It works fine with GMod's localization system:
localizationdemo.mp4
localizationdemo2.mp4
Partly solves this: Facepunch/garrysmod-issues#6096