feat: cache data #16
Merged
feat: cache data #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Serein207
force-pushed
the
dev
branch
2 times, most recently
from
b1401af
to
45b18a2
Compare
Serein207
force-pushed
the
feat/net/cache
branch
from
d806bb7
to
dad2d5c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Serein207
force-pushed
the
feat/net/cache
branch
from
d33a079
to
dad2d5c
Compare
Serein207
force-pushed
the
feat/net/cache
branch
from
dad2d5c
to
8024806
Compare
Closed
|
|
把和cache有关的封装成独立的类，不要全都塞在 |
…quest<api::Evento> and request<api::Github> in 'NetworkClient.h'
…ing functionality(TTL=3 hours) into existing codes in 'NetworkClient.h'
…nd aux function updateCache in 'NetworkClient.h'
…File,generateFilename
Serein207
force-pushed
the
feat/net/cache
branch
from
e953179
to
75856c0
Compare
Serein207
force-pushed
the
feat/net/cache
branch
from
8bb5b71
to
19f1efd
Compare
Serein207
force-pushed
the
feat/net/cache
branch
from
7f6372d
to
2b02530
Compare
Serein207
force-pushed
the
feat/net/cache
branch
from
0b6532a
to
ea21e81
Compare
Serein207
force-pushed
the
feat/net/cache
branch
from
560bc5f
to
274e78d
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Serein207
approved these changes
Aug 29, 2024
zwow-cj
pushed a commit
that referenced
this pull request
Aug 30, 2024
* create cache and aux function generateCacheKey in class NetworkClient * create cache and aux function generateCacheKey in class NetworkClient * feat: add cacheKey generating,cache Checking and cache Updating to request<api::Evento> and request<api::Github> in 'NetworkClient.h' * feat: add struct CacheEntry ,bool isCacheEntryExpired and cacheExpireing functionality(TTL=3 hours) into existing codes in 'NetworkClient.h' * feat: modify data struct of cache and add LRU cacheLimit up to 64MB and aux function updateCache in 'NetworkClient.h' * feat: cache exceptions handler * feat: photos cache in HttpAccessManager,providing aux functionssaveToFile,generateFilename * fix: merge from branch dev and fix the type matching problem * perf: improve performance and fix potential problems * refactor: cache manager * feat: download file * feat: get cache size * feat: support request cache * feat: use ttl --------- Co-authored-by: Serein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache
data type:
Expectation
After that