Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AliceVision #224262

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add AliceVision #224262

wants to merge 3 commits into from

Conversation

hesiod
Copy link
Contributor

@hesiod hesiod commented Apr 1, 2023

Description of changes

Add AliceVision.

Currently includes PR #216401 and commits updating Clp, Osi and adding CoinUtils. I might move the latter changes into another PR.
Edit: This PR is now independent of the other PRs.

Some features of AliceVision are not enabled in this PR because they require further testing/packaging, CUDA support being the most notable feature. I'm personally not interested in adding them at the moment, but others are welcome to add support.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@hesiod hesiod mentioned this pull request Apr 1, 2023
19 tasks
@ofborg ofborg bot requested review from abbradar, ttuegel and vbgl April 1, 2023 20:01
@vbgl vbgl removed their request for review April 2, 2023 12:11
@hesiod hesiod requested review from davidak and removed request for abbradar and ttuegel April 2, 2023 12:12
@hesiod
Copy link
Contributor Author

hesiod commented Apr 2, 2023

I removed some reviewers that were picked up by Borg as a false positive (due to the contained other commits). Sorry for the noise. You're still welcome to review though.

@hesiod
Copy link
Contributor Author

hesiod commented Apr 2, 2023

Result of nixpkgs-review pr 224262 run on x86_64-linux 1

3 packages built:
  • alice-vision
  • alice-vision.dev
  • alice-vision.lib

@hesiod hesiod force-pushed the alice-vision branch 2 times, most recently from 8983de9 to eea47bb Compare April 4, 2023 00:39
@hesiod hesiod marked this pull request as draft April 4, 2023 14:01
@hesiod hesiod force-pushed the alice-vision branch 5 times, most recently from 668f369 to 6fb1084 Compare April 8, 2023 14:09
@hesiod
Copy link
Contributor Author

hesiod commented Apr 10, 2023

@ofborg eval
@ofborg build alice-vision

@hesiod
Copy link
Contributor Author

hesiod commented May 23, 2023

Result of nixpkgs-review pr 224262 run on x86_64-linux 1

7 packages built:
  • alice-vision
  • alice-vision.dev
  • geogram
  • geogram.bin
  • geogram.dev
  • geogram.doc
  • geogram.lib

@hesiod hesiod marked this pull request as ready for review May 23, 2023 21:32
Laurent2916 added a commit to alicevision/AliceVision that referenced this pull request Jun 16, 2023
@pbsds
Copy link
Member

pbsds commented Jun 29, 2023

Result of nixpkgs-review pr 224262 run on x86_64-linux 1

2 packages failed to build:
  • alice-vision
  • alice-vision.dev
5 packages built:
  • geogram
  • geogram.bin
  • geogram.dev
  • geogram.doc
  • geogram.lib
alice-vision> /build/source/src/aliceVision/fuseCut/DelaunayGraphCut.cpp:210:33: error: 'SearchParams' in namespace 'nanoflann' does not name a type; did you mean 'SearchParameters'?
alice-vision>   210 |         static const nanoflann::SearchParams searchParams(32, 0, false); // false: dont need to sort
alice-vision>       |                                 ^~~~~~~~~~~~
alice-vision>       |                                 SearchParameters
alice-vision> /build/source/src/aliceVision/fuseCut/DelaunayGraphCut.cpp:212:74: error: 'searchParams' was not declared in this scope
alice-vision>   212 |         kdTree.findNeighbors(resultSet, verticesCoordsPrepare[vIndex].m, searchParams);
alice-vision>       |                                                                          ^~~~~~~~~~~~
alice-vision> /build/source/src/aliceVision/fuseCut/DelaunayGraphCut.cpp: In function 'void aliceVision::fuseCut::createVerticesWithVisibilities(const aliceVision::StaticVector<int>&, std::vector<aliceVision::Point3d>&, std::vector<double>&, std::vector<float>&, std::vector<GC_vertexInfo>&, aliceVision::mvsUtils::MultiViewParams&, float, float, float, float)':
alice-vision> /build/source/src/aliceVision/fuseCut/DelaunayGraphCut.cpp:349:69: error: 'SearchParams' is not a member of 'nanoflann'; did you mean 'SearchParameters'?
alice-vision>   349 |                 if(!kdTree.findNeighbors(resultSet, p.m, nanoflann::SearchParams()))
alice-vision>       |                                                                     ^~~~~~~~~~~~
alice-vision>       |                                                                     SearchParameters

@zeuner
Copy link
Contributor

zeuner commented Sep 7, 2023

I just noticed this merge request when uploading another working (compiles and successfully runs reconstruction pipelines on x86_64) build: 8411621

What's the status? Maybe a mismatch in nanoflann versions?

@luzpaz
Copy link
Contributor

luzpaz commented Jan 21, 2024

bumping for status. Asking due to #216403

@zeuner
Copy link
Contributor

zeuner commented Jan 21, 2024

bumping for status. Asking due to #216403

I started another PR for adding AliceVision: #256115

If there is interest, I can update it (needs a rebase by now).

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants