Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfb: ensure logging of incompletely parsed txs #9106

Closed
wants to merge 1 commit into from

Conversation

satta
Copy link
Contributor

@satta satta commented Jun 29, 2023

Link to redmine ticket: #5912

Describe changes:

@satta satta requested a review from jasonish as a code owner June 29, 2023 22:22
@jasonish
Copy link
Member

Is an S-V test possible that shows failure in master, but success after this PR?

@satta
Copy link
Contributor Author

satta commented Jun 30, 2023

Is an S-V test possible that shows failure in master, but success after this PR?

I'll see if I can get a pcap of, say, an Apple RFB session, for which there is no authentication parsing, and see if I can get partial events logged.

@satta
Copy link
Contributor Author

satta commented Jun 30, 2023

Found one, see OISF/suricata-verify#1274. Will open a new PR using that.

@satta satta mentioned this pull request Jun 30, 2023
@satta
Copy link
Contributor Author

satta commented Jun 30, 2023

Next PR: #9114

@satta satta closed this Jun 30, 2023
@satta satta deleted the log-rfb-skipped-tx branch July 2, 2023 18:45
@satta satta mentioned this pull request Jul 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants