-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log rfb skipped tx v2 #9114
Log rfb skipped tx v2 #9114
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9114 +/- ##
==========================================
- Coverage 82.31% 82.27% -0.04%
==========================================
Files 969 969
Lines 273722 273735 +13
==========================================
- Hits 225307 225215 -92
- Misses 48415 48520 +105
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI : green
Code : ok, I wonder if a wrapper around these 5 lines would be nicer
Commits segmentation : ok
Commit messages : ok, but I would have added the ticket number as you promised ;-p
Git ID set : looks fine for me
CLA : ok
Doc update : not needed
Redmine ticket : ok
Rustfmt : ok
Tests : ok, test with an unknown security type is always welcome
Dependencies added: none
Divisions : none
Well, I omitted it because an earlier commit fixed the Redmine issue, this one just addressed another point. Or do you mean the GitHub issue number? |
As this PR completes the previous commit, I would have noted the redmine issue, so that both commits get back ported if needed |
Merged in #9143, thanks! |
Previous PR: #9106
Link to redmine ticket: #5912
Describe changes to previous PR:
OISF/suricata-verify#1279