Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log rfb skipped tx v2 #9114

Closed
wants to merge 2 commits into from
Closed

Log rfb skipped tx v2 #9114

wants to merge 2 commits into from

Conversation

satta
Copy link
Contributor

@satta satta commented Jun 30, 2023

Previous PR: #9106

Link to redmine ticket: #5912

Describe changes to previous PR:

  • Reference S-V test PR as requested.
  • Make sure that we also set parsed values in the event even if we skip parsing at some point.

OISF/suricata-verify#1279

SV_BRANCH=pr/1279

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #9114 (87227ac) into master (d822ba5) will decrease coverage by 0.04%.
The diff coverage is 36.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9114      +/-   ##
==========================================
- Coverage   82.31%   82.27%   -0.04%     
==========================================
  Files         969      969              
  Lines      273722   273735      +13     
==========================================
- Hits       225307   225215      -92     
- Misses      48415    48520     +105     
Flag Coverage Δ
fuzzcorpus 64.55% <36.84%> (-0.05%) ⬇️
suricata-verify 60.61% <26.31%> (+0.01%) ⬆️
unittests 62.89% <26.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI : green
Code : ok, I wonder if a wrapper around these 5 lines would be nicer
Commits segmentation : ok
Commit messages : ok, but I would have added the ticket number as you promised ;-p
Git ID set : looks fine for me
CLA : ok
Doc update : not needed
Redmine ticket : ok
Rustfmt : ok
Tests : ok, test with an unknown security type is always welcome
Dependencies added: none
Divisions : none

@satta
Copy link
Contributor Author

satta commented Jun 30, 2023

Commit messages : ok, but I would have added the ticket number as you promised ;-p

Well, I omitted it because an earlier commit fixed the Redmine issue, this one just addressed another point. Or do you mean the GitHub issue number?

@catenacyber
Copy link
Contributor

Commit messages : ok, but I would have added the ticket number as you promised ;-p

Well, I omitted it because an earlier commit fixed the Redmine issue, this one just addressed another point. Or do you mean the GitHub issue number?

As this PR completes the previous commit, I would have noted the redmine issue, so that both commits get back ported if needed

@victorjulien
Copy link
Member

Merged in #9143, thanks!

@satta satta deleted the log-rfb-skipped-tx-v2 branch July 12, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants