-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnint 64to32 6186 v18 #9840
Warnint 64to32 6186 v18 #9840
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9840 +/- ##
==========================================
- Coverage 82.42% 82.42% -0.01%
==========================================
Files 972 972
Lines 273929 274009 +80
==========================================
+ Hits 225788 225842 +54
- Misses 48141 48167 +26
Flags with carried forward coverage won't be shown. Click here to find out more. |
WARNING:
Pipeline 16645 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs review of the defrag QA result.
Maybe it's a good idea to split the PR so we can already get parts merged. |
@ct0br0 can you have a |
Should I make a PR with just the first commit out of the 17 ones ? |
d7ff4ac
to
40edf5b
Compare
ERROR: ERROR: QA failed on build_asan. Pipeline 16672 |
Closing as needing rebase, and split in multiple future PRs like #9878 |
[Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32
warnings for some filesOISF/libhtp#399
#9811 with core review taken into account
There must be some stuff to review more carefully
QA needs to be checked for defrag (and then have a git bisect...)