Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnint 64to32 6186 v18 #9840

Closed
wants to merge 17 commits into from

Conversation

catenacyber
Copy link
Contributor

[Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186

Describe changes:

  • fix -Wshorten-64-to-32 warnings for some files
  • Add CI build with this warning
LIBHTP_BRANCH=pr/399

OISF/libhtp#399

#9811 with core review taken into account

There must be some stuff to review more carefully

QA needs to be checked for defrag (and then have a git bisect...)

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Merging #9840 (d7ff4ac) into master (d2b25af) will decrease coverage by 0.01%.
The diff coverage is 70.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9840      +/-   ##
==========================================
- Coverage   82.42%   82.42%   -0.01%     
==========================================
  Files         972      972              
  Lines      273929   274009      +80     
==========================================
+ Hits       225788   225842      +54     
- Misses      48141    48167      +26     
Flag Coverage Δ
fuzzcorpus 64.30% <59.21%> (+0.01%) ⬆️
suricata-verify 61.07% <63.84%> (-0.02%) ⬇️
unittests 62.86% <36.20%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.decoder.event.ipv4.frag_overlap 805 511 63.48%

Pipeline 16645

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs review of the defrag QA result.

@victorjulien
Copy link
Member

Maybe it's a good idea to split the PR so we can already get parts merged.

@catenacyber
Copy link
Contributor Author

Needs review of the defrag QA result.

@ct0br0 can you have a git bisect for this QA deviation ?

@catenacyber
Copy link
Contributor Author

Maybe it's a good idea to split the PR so we can already get parts merged.

Should I make a PR with just the first commit out of the 17 ones ?

@catenacyber catenacyber marked this pull request as draft November 20, 2023 21:04
@suricata-qa
Copy link

ERROR:

ERROR: QA failed on build_asan.

Pipeline 16672

@catenacyber catenacyber added the needs rebase Needs rebase to master label Nov 21, 2023
@catenacyber
Copy link
Contributor Author

Closing as needing rebase, and split in multiple future PRs like #9878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
Development

Successfully merging this pull request may close these issues.

3 participants