Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Clang tidy fixes #155

Open
wants to merge 8 commits into
base: eloquent-devel
Choose a base branch
from

Conversation

nbbrooks
Copy link
Member

@nbbrooks nbbrooks commented Jun 3, 2020

No description provided.

@auto-assign auto-assign bot requested a review from davetcoleman June 3, 2020 00:24
@@ -1,66 +0,0 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this deleted?

@@ -84,7 +84,7 @@ static const double SMALL_SCALE = 0.001;
static const double LARGE_SCALE = 100;

// Note: when adding new colors to colors, also add them to getRandColor() function
enum colors
enum Colors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will break a lot of existing code, are we sure its necessary?

<name>rviz_visual_tools</name>
<version>3.7.0</version>
<description>Utility functions for displaying and debugging data in Rviz via published markers</description>

<maintainer email="[email protected]">Mike Lautman</maintainer>
<author email="[email protected]">Mike Lautman</author>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlautman I'm not sure why I was removed as an author, I wrote most of this package myself in grad school.

Suggested change
<author email="mike@picknik.ai">Mike Lautman</author>
<author email="dave@picknik.ai">Dave Coleman</author>
<author email="[email protected]">Mike Lautman</author>

@@ -1,22 +1,20 @@
<?xml version="1.0"?>
<package format="2">
<package format="3">
<name>rviz_visual_tools</name>
<version>3.7.0</version>
<description>Utility functions for displaying and debugging data in Rviz via published markers</description>

<maintainer email="[email protected]">Mike Lautman</maintainer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbbrooks should you be listed as maintainer also? You seem to be doing a lot on this package

@nbbrooks nbbrooks changed the title Clang tidy fixes WIP: Clang tidy fixes Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants