WIP: Clang tidy fixes

.travis.yml

@@ -1,26 +1,23 @@
-# This config file for Travis CI utilizes https://github.com/ros-planning/moveit_ci package.
-sudo: required
-dist: xenial  # distro used by Travis, moveit_ci uses the docker image's distro
+language: generic
 services:
   - docker
-language: cpp
-compiler: gcc
-cache: ccache
+
+cache:
+  directories:
+    - $HOME/.ccache
+
+git:
+  quiet: true
 
 env:
   global:
-    - ROS_DISTRO=eloquent
     - ROS_REPO=ros
-    - CXXFLAGS="-Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wredundant-decls -Wno-unused-parameter -Wno-unused-function"
-    - WARNINGS_OK=false
+    - CCACHE_DIR=$HOME/.ccache
+    - UPSTREAM_WORKSPACE="rviz_visual_tools.repos"
   matrix:
-    - TEST="clang-format" # TODO(davetcoleman): enable catkin_lint in the future
-    - TEST=clang-tidy-fix
-    - TEST=clang-tidy-check
-    - ROS_DISTRO=eloquent
-
-before_script:
-  - git clone -q -b ros2 --depth=1 https://github.com/ros-planning/moveit_ci.git .moveit_ci
+    - ROS_DISTRO="eloquent"
 
+install:
+  - git clone --quiet --depth 1 https://github.com/ros-industrial/industrial_ci.git .industrial_ci -b master
 script:
-  - .moveit_ci/travis.sh
+  - .industrial_ci/travis.sh

CMakeLists.txt

@@ -230,6 +230,10 @@ ament_export_libraries(
 ## TEST ##
 ##########
 if (BUILD_TESTING)
+  # ROS2 linters
+  find_package(ament_lint_auto REQUIRED)
+  ament_lint_auto_find_test_dependencies()
+
   # Run tests
   find_package(ament_cmake_gtest REQUIRED)
   ament_add_gtest(${PROJECT_NAME}_rvt_test
@@ -244,4 +248,4 @@ if (BUILD_TESTING)
   )
 endif()
 
-ament_package()
+ament_package()

include/rviz_visual_tools/remote_control.hpp

@@ -47,6 +47,7 @@
 // ROS
 #include <rclcpp/rclcpp.hpp>
 #include <sensor_msgs/msg/joy.hpp>
+#include <utility>
 
 namespace rviz_visual_tools
 {
@@ -121,7 +122,7 @@ class RemoteControl
 
   void setDisplayWaitingState(DisplayWaitingState displayWaitingState)
   {
-    displayWaitingState_ = displayWaitingState;
+    displayWaitingState_ = std::move(displayWaitingState);
   }
 
 private: