add >18 energy storage techologies #67
Conversation
| # While the first segment is known, the others are defined by the initial segments with a accumulating quadratic descreasing gradient | ||
| other_segments_points = [2034, 2039, 2044, 2049, 2054, 2059] | ||
|
|
||
| def geometric_series(nominator, denominator=1, number_of_terms=1, start=1): |
There was a problem hiding this comment.
Can you change this, to either find cost assumptions for 2050 or assuming the same cost assumptions for the following years from 2030 onwards?
There was a problem hiding this comment.
2050 assumptions for all >18 technologies dont' exist.
I would suggest to:
- keep this geometric series approach (needs to be fine-tuned in future, but reflect more reality)
- create a new option to cap the costs at 2030 (really pessimistic)
There was a problem hiding this comment.
The config.yaml now has the option approx_beyond_2030 with two options "geometric_series" (optimistic that technologies will improve) and "same_as_2030" (very pessimistic assuming costs are not decreasing after 2030). Below I am also just showing briefly that the options work fine.
Option "same_as_2030"
2020 results
2030 results
2050 results
Option "geometric_series"
2050 results
|
Thanks for the review @lisazeyen You spotted some issues. 👍 |
|
@lisazeyen sorry for working on this PR that late. Some other stuff came in between. The PR is ready for review, and I added comments to every open Q. Let me know if you have any questions. If you approve all changes, I will upload all the outputs (they typically lead to merge conflicts that's why I would wait just before the intention to merge). |
| # add fuel cell/electrolysis efficiencies from Budischak (DEA assumptions very conservative) | ||
| h2_from_budischak : false | ||
| energy_storage_database: | ||
| h2_from_budischak: true # add fuel cell/electrolysis efficiencies from Budischak (DEA assumptions very conservative) |
There was a problem hiding this comment.
probably by accident the h2_from_budischak moved below energy_storage_database, should be separate
There was a problem hiding this comment.
Yep, the energy_storage_database aims to keep all energy storage relevant data options in one place, addressing your comment. It's just a proposal happy to revert.
|
Thanks @pz-max ! |
Changes proposed in this Pull Request
This PR adds about 18 energy storage technologies from a PNNL report. The implementation will be tested in PyPSA-Earth and should be merged into main only after this proof of concept (so this is work in progress).
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.