Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvments to resfinder and amrfinder parser #9

Merged
merged 8 commits into from
Dec 12, 2023

Conversation

mhkc
Copy link
Collaborator

@mhkc mhkc commented Dec 12, 2023

This PR improves the parsing of resfinder and AMRfinder results to increase the number of fields used. It also fixes an issue that prevented parsing of AMRfinder results.

Closes #7 #6 #5

Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhkc mhkc merged commit 51d5821 into master Dec 12, 2023
7 checks passed
@mhkc mhkc deleted the improve-resfinder-parser branch December 12, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants