Added transfer of RAD tokens to ScopeLift upon successful upgrade to governor Bravo #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
alexkeating
reviewed
Dec 6, 2023
test/RadworksGovernor.t.sol
Outdated
| uint256 _timelockTokenBalance = _token.balanceOf(TIMELOCK); | ||
|
|
||
| // bound by the number of tokens the timelock currently controls | ||
| _amount = bound(_amount, 0, _timelockTokenBalance); | ||
| uint256 _initialTokenBalance = _token.balanceOf(_receiver); | ||
|
|
||
| _upgradeToBravoGovernor(); |
There was a problem hiding this comment.
It may better to keep this test as is and assume the token does not equal the rad token, and create a new test specifically for the RAD token which subtracts the expected ScopeLift amount from the _timelockTokenBalance. In this setup a test will fail if an unexpected amount of tokens is transferred during the upgrade where as I think this will not.
jferas
force-pushed
the
separate-alpha-tests
branch
from
b2af40e
to
354cfbc
Compare
jferas
force-pushed
the
scopelift-tokens
branch
from
1bdb4f1
to
f25f7d4
Compare
jferas
force-pushed
the
separate-alpha-tests
branch
from
354cfbc
to
bf76141
Compare
jferas
force-pushed
the
scopelift-tokens
branch
from
f25f7d4
to
4d030e5
Compare
jferas
force-pushed
the
separate-alpha-tests
branch
from
bf76141
to
fe8a3aa
Compare
jferas
force-pushed
the
scopelift-tokens
branch
2 times, most recently
from
1b6cb61
to
eec664b
Compare
jferas
force-pushed
the
scopelift-tokens
branch
from
eec664b
to
689b261
Compare
alexkeating
approved these changes
Dec 7, 2023
This was referenced Dec 8, 2023
wildmolasses
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a transfer of RAD tokens to ScopeLift as part of the transaction that upgrades to Governor Bravo.
Resolves #17