Added tests for changing admin/upgrading protocol via governance #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
alexkeating
reviewed
Dec 8, 2023
test/RadworksDripsGovernance.t.sol
Outdated
| @@ -118,6 +164,34 @@ abstract contract RadworksDripsGovernance is ProposalTest { | |||
| // Ensure the admin role has been renounced | |||
| assertEq(drips.admin(), address(0)); | |||
| } | |||
|
|
|||
| function test_proposeNewAdminViaGovernance(address _newAdmin) public { | |||
There was a problem hiding this comment.
Name should be testFuzz_ProposaNewAdminViaGovernance
alexkeating
approved these changes
Dec 12, 2023
test/RadworksDripsGovernance.t.sol
Outdated
| import {ProposalTest} from "test/helpers/ProposalTest.sol"; | ||
|
|
||
| import {console2} from "forge-std/console2.sol"; |
test/RadworksDripsGovernance.t.sol
Outdated
| import {ProposalTest} from "test/helpers/ProposalTest.sol"; | ||
|
|
||
| import {console2} from "forge-std/console2.sol"; | ||
|
|
||
| /// @dev This contract used in the testing of using governance to upgrade the Drips protocol |
There was a problem hiding this comment.
"is used in the testing of governance to upgrade the Drips protocol*.*" this sounds a little better
jferas
force-pushed
the
drips-admin-tests
branch
from
cfabece
to
ec11571
Compare
wildmolasses
approved these changes
Dec 20, 2023
jferas
force-pushed
the
drips-admin-tests
branch
from
ec11571
to
79efaea
Compare
jferas
force-pushed
the
drips-admin-tests
branch
from
79efaea
to
7ffeb0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for changing admin via governance
Add Drips protocol upgrade via governance tests