Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to jmd tutorials #113

Merged
merged 51 commits into from
Apr 23, 2021
Merged

Move to jmd tutorials #113

merged 51 commits into from
Apr 23, 2021

Conversation

cpfiffer
Copy link
Member

Resolves #86 by merging all the stuff @torfjelde has done to get us up and running on .jmd style tutorials.

The deploy plan here is a little complicated, but I want to merge this stuff first before I go fix the non-tutorial stuff elsewhere -- the tutorials are a bigger issue IMO and I'm fine with having some weird formatting for a couple hours while I figure out the kinks. In general it looks like we have all the right directories and everything, so there shouldn't be any breakage.

torfjelde and others added 30 commits September 24, 2020 12:46
Bobbing and weaving in the new setup
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cpfiffer
Copy link
Member Author

Ugh I hate merge conflicts, please ignore me

@devmotion
Copy link
Member

😮😮
Screenshot_20210327-191255_1.png

@cpfiffer
Copy link
Member Author

Most of that is us losing a ton of boilerplate Jupyter crap.

@cpfiffer
Copy link
Member Author

I'm rerunning some of the tutorials on 1.6 just to make sure we're good, then I'll push them to the branch.

@torfjelde
Copy link
Member

Awesooome! I'm so excited 🎉

Btw, I made all those changes line-by-line 😎

@cpfiffer
Copy link
Member Author

cpfiffer commented Apr 5, 2021

Only issue left is on the NN tutorial:

Error: MethodError: ReverseDiff.TrackedReal{Float64, Float64, ReverseDiff.T
rackedArray{Float64, Float64, 2, Matrix{Float64}, Matrix{Float64}}}(::Forwa
rdDiff.Dual{ForwardDiff.Tag{ReverseDiff.var"#105#107"{DataType, Tuple{}, Va
l{(1,)}}, Float64}, Float64, 1}) is ambiguous. Candidates:
  (T::Type{var"#s31"} where var"#s31"<:Real)(x::ForwardDiff.Dual) in Tracke
r at /home/cameron/.julia/packages/Tracker/YNNTM/src/lib/real.jl:111
  ReverseDiff.TrackedReal{V, D, O}(value) where {V, D, O} in ReverseDiff at
 /home/cameron/.julia/packages/ReverseDiff/iHmB4/src/tracked.jl:56
Possible fix, define
  ReverseDiff.TrackedReal{V, D, O}(::ForwardDiff.Dual) where {V, D, O}

I recall this bug at some point, currently digging through stuff to track it down.

@leachim
Copy link
Collaborator

leachim commented Apr 8, 2021

Hi there, I did some work on the HMM tutorial, to address some issues that have been raised (#114, TuringLang/Turing.jl#1411, TuringLang/Turing.jl#1528, TuringLang/Turing.jl#1302). I saw that you fixed some of it already, but I further updated the example, so it properly converges and I rewrote some of the parts at the end. Is it okay if I open a pull request here, I based it on the jmd-staging branch?

@cpfiffer
Copy link
Member Author

cpfiffer commented Apr 8, 2021

Is it okay if I open a pull request here, I based it on the jmd-staging branch?

Yep, that's correct, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorials are largely outdated
4 participants