Implement Thermal Mgr Task #285

sardormirk · 2024-03-30T04:21:15Z

Purpose

Implement Thermal Manager Task
Created a skeleton thermal manager task function to replace the health collector

New Changes

Created a new thermal manager module to replace health collector
Added the task configuration to obc_scheduler_config
added necessary declarations to obc watchdog and digital watchdog

Outstanding Changes

Needs to measure other ICs (not just LM75BD temp sensor) and log their telemetry data
Needs to add alerts for fault conditions
Needs algorithm to control battery heater

github-actions · 2024-03-30T04:21:30Z

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

	User	Total reviews	Time to review	Total comments
	dgobalak	25	1d 5h 24m	134
	Navtajh04	18	4d 7h 34m	108
	Yarik-Popov	12	6d 11h 3m	90
	PratyushMakkar	5	7d 14h 7m	22
	Gjjjiang	4	4d 15h 52m	14
	manumanuk	2	35d 14h 41m	5
	twilkhoo	1	4m	0
	JoelManYunLee	1	17h 57m	4
	kepler452b123	1	7d 4h 25m	11
^{⚡️ Pull request stats}

Yarik-Popov · 2024-03-30T19:59:05Z

obc/app/modules/thermal_mgr/thermal_mgr.c


-static obc_error_code_t collectObcLm75bdTemp(void);
+void obcTaskInitThermalMgr() {}


This task should init the lm75bd

Yarik-Popov · 2024-03-30T20:01:02Z

obc/app/modules/thermal_mgr/thermal_mgr.c


-#define HEALTH_COLLECTION_PERIOD_MS 60000UL
+#define THERMAL_MGR_PERIOD_MS 1000


Based on our telemetry sheet, it should take the temperature once every minute, not once a sec. Also add U to the end

Yarik-Popov · 2024-03-30T20:03:27Z

obc/app/modules/digital_watchdog_mgr/digital_watchdog_mgr.c

-#define TASK_HEALTH_COLLECTOR_WATCHDOG_TIMEOUT portMAX_DELAY
+#define TASK_THERMAL_MGR_WATCHDOG_TIMEOUT pdMS_TO_TICKS(1000)


Update this with changed tick delay

Yarik-Popov · 2024-03-30T20:04:30Z

obc/app/modules/thermal_mgr/thermal_mgr.c


-static obc_error_code_t collectObcLm75bdTemp(void);
+void obcTaskInitThermalMgr() {}
+ static obc_error_code_t collectObcLm75bdTemp(void);


Push this above the obcTaskInit function

Navtajh04 · 2024-05-24T08:06:55Z

obc/app/modules/digital_watchdog_mgr/digital_watchdog_mgr.c

@@ -23,7 +23,7 @@
 #define TASK_PAYLOAD_MGR_WATCHDOG_TIMEOUT portMAX_DELAY
 #define TASK_TIMEKEEPER_WATCHDOG_TIMEOUT portMAX_DELAY
 #define TASK_ALARM_MGR_WATCHDOG_TIMEOUT portMAX_DELAY
-#define TASK_HEALTH_COLLECTOR_WATCHDOG_TIMEOUT portMAX_DELAY
+#define TASK_THERMAL_MGR_WATCHDOG_TIMEOUT pdMS_TO_TICKS(1000)


watchdog timeout shouldl generally be 2x task rate

Navtajh04 · 2024-05-24T08:12:16Z

obc/app/modules/thermal_mgr/thermal_mgr.c


  while (1) {
    LOG_IF_ERROR_CODE(collectObcLm75bdTemp());
-    vTaskDelay(pdMS_TO_TICKS(HEALTH_COLLECTION_PERIOD_MS));


we should be implementing these mailboxes in this pr https://discord.com/channels/831191521595621387/1124186460866740314/1181054461494444082

Don;t need to have other tasks sending anything to the queue right now but the queues and thermal mgr side shpuld be set up

Navtajh04 · 2024-05-24T08:17:38Z

obc/app/modules/thermal_mgr/thermal_mgr.c

 }

-static obc_error_code_t collectObcLm75bdTemp(void) {
+ static obc_error_code_t collectObcLm75bdTemp(void) {


nit: fix indent

Navtajh04 · 2024-05-24T08:17:54Z

obc/app/modules/thermal_mgr/thermal_mgr.c


-static obc_error_code_t collectObcLm75bdTemp(void);
+void obcTaskInitThermalMgr() {}
+ static obc_error_code_t collectObcLm75bdTemp(void);


nit: fix indent

Navtajh04 · 2024-05-24T08:20:30Z

obc/app/modules/thermal_mgr/thermal_mgr.c

@@ -36,4 +45,5 @@ static obc_error_code_t collectObcLm75bdTemp(void) {
  RETURN_IF_ERROR_CODE(addTelemetryData(&obcTempVal));


make telem a flag that is passed in since we may want to just read the value sometimes to make sure we are safe without adding that as telemetry

…alt in different pr)

superkor · 2024-11-06T22:42:39Z

obc/app/drivers/cc1120/cc1120.h

@@ -171,3 +171,5 @@ obc_error_code_t cc1120GetState(cc1120_state_t *stateNum);
 * @return obc_error_code_t - Whether or not the setup was a success
 */
 obc_error_code_t cc1120Init(void);
+
+obc_error_code_t readTempCC1120(float *temp);


https://discord.com/channels/831191521595621387/1124186460866740314/1301569668242472980

Adding common interface into the header file

superkor · 2024-11-06T22:43:00Z

obc/app/modules/thermal_mgr/thermal_mgr.c

 static obc_error_code_t collectObcCC1120Temp(void);
-static obc_error_code_t setObcCC1120TempReading(void);
-static obc_error_code_t resetObcCC120TempConfig(void);


This will be handled in a different PR (driver functions are being written in it - not in the scope of this PR)

superkor · 2024-11-06T22:43:21Z

obc/app/modules/thermal_mgr/thermal_mgr.c

-    LOG_IF_ERROR_CODE(collectObcDs3232Temp());
+    LOG_IF_ERROR_CODE(collectObcDs3232Temp());  // RTC
+    // BMS in pr https://github.com/UWOrbital/OBC-firmware/pull/187
+


BMS driver code does not exist; still in PR #187

fixed thermal mgr task hopefully no merge conflicts this time

c2caffd

Yarik-Popov requested changes Mar 30, 2024

View reviewed changes

Yarik-Popov changed the title ~~fixed thermal mgr task hopefully no merge conflicts this time~~ Implement thermal mgr task Mar 30, 2024

Yarik-Popov changed the title ~~Implement thermal mgr task~~ Implement Thermal Mgr Task Mar 30, 2024

Navtajh04 requested changes May 24, 2024

View reviewed changes

Yarik-Popov mentioned this pull request Sep 19, 2024

Sardor/thermal mgr task #283

Closed

superkor self-assigned this Oct 26, 2024

superkor added 4 commits October 29, 2024 17:41

add temp telemetary on some ICs - CC1120 temp needs calibration

d13a987

fix compilation errors

72b7235

hopefully fix merge conflict

38111b7

add readTempCC1120 function prototype and remove cc1120 temp code (de…

19bd58c

…alt in different pr)

superkor reviewed Nov 6, 2024

View reviewed changes

superkor added 2 commits November 20, 2024 17:53

add telemetry constants for the ICs/BMS

fb02de2

fix build error

83d5389

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Thermal Mgr Task #285

Implement Thermal Mgr Task #285

sardormirk commented Mar 30, 2024

github-actions bot commented Mar 30, 2024

Yarik-Popov Mar 30, 2024

Yarik-Popov Mar 30, 2024

Yarik-Popov Mar 30, 2024

Yarik-Popov Mar 30, 2024

Navtajh04 May 24, 2024

Navtajh04 May 24, 2024

Navtajh04 May 24, 2024

Navtajh04 May 24, 2024

Navtajh04 May 24, 2024

superkor Nov 6, 2024

superkor Nov 6, 2024

superkor Nov 6, 2024


		static obc_error_code_t collectObcLm75bdTemp(void);
		void obcTaskInitThermalMgr() {}


		#define HEALTH_COLLECTION_PERIOD_MS 60000UL
		#define THERMAL_MGR_PERIOD_MS 1000

		#define TASK_HEALTH_COLLECTOR_WATCHDOG_TIMEOUT portMAX_DELAY
		#define TASK_THERMAL_MGR_WATCHDOG_TIMEOUT pdMS_TO_TICKS(1000)

		@@ -36,4 +45,5 @@ static obc_error_code_t collectObcLm75bdTemp(void) {
		RETURN_IF_ERROR_CODE(addTelemetryData(&obcTempVal));

Implement Thermal Mgr Task #285

Are you sure you want to change the base?

Implement Thermal Mgr Task #285

Conversation

sardormirk commented Mar 30, 2024

Purpose

New Changes

Outstanding Changes

github-actions bot commented Mar 30, 2024

Pull reviewers stats

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment