feat(universal-router-sdk): separate esm / cjs builds #221
+64
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 16, 2024
just-toby
force-pushed
the
feat/permit2-sdk-build
branch
from
d061f25 to
aac8085
Compare
just-toby
force-pushed
the
feat/universal-router-sdk-esm-build
branch
from
1950758 to
0794387
Compare
just-toby
force-pushed
the
feat/permit2-sdk-build
branch
from
aac8085 to
73d5b8b
Compare
just-toby
force-pushed
the
feat/universal-router-sdk-esm-build
branch
from
0794387 to
88fd603
Compare
just-toby
force-pushed
the
feat/permit2-sdk-build
branch
from
73d5b8b to
f2c31ef
Compare
just-toby
force-pushed
the
feat/universal-router-sdk-esm-build
branch
from
88fd603 to
e8c6e06
Compare
just-toby
force-pushed
the
feat/permit2-sdk-build
branch
from
f2c31ef to
4781fa9
Compare
just-toby
force-pushed
the
feat/universal-router-sdk-esm-build
branch
from
e8c6e06 to
8d79889
Compare
just-toby
force-pushed
the
feat/permit2-sdk-build
branch
from
4781fa9 to
c0a6a1d
Compare
just-toby
force-pushed
the
feat/universal-router-sdk-esm-build
branch
from
8d79889 to
2a00e31
Compare
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/16/24)1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
just-toby
force-pushed
the
feat/permit2-sdk-build
branch
2 times, most recently
from
4fc3bee to
9311793
Compare
just-toby
force-pushed
the
feat/universal-router-sdk-esm-build
branch
from
2a00e31 to
c55fb49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
breaking change to build structure for
universal-router-sdkDescription
updates the build setup for
universal-router-sdkto manually and explicitly create separate cjs and esm builds (plus a types-only version)How Has This Been Tested?
built the sdk locally, then installed the local build result in another project (
universe/apps/web) and verified that it properly resolved the esm version instead of the cjs versionAre there any breaking changes?
there shouldn't be, but technically if an end user is importing incorrectly (by directly referencing any build artifact files) then they'll need to update
(Optional) Follow Ups
PRs to follow will do this for many other SDKs