Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated strings from Crowdin 2024/09/30 13:15 #17168

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Updated strings from Crowdin 2024/09/30 13:15 #17168

merged 1 commit into from
Sep 30, 2024

Conversation

mikehardy-machineaccount
Copy link
Collaborator

Contains the newest strings changes from Crowdin.

https://crowdin.com/project/ankidroid/activity-stream

@welcome Welcome
Copy link

welcome bot commented Sep 30, 2024

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

david-allison
david-allison reviewed Sep 30, 2024
View reviewed changes
AnkiDroid/src/main/res/values-gu/06-statistics.xml Outdated
<string name="stats_overview_days">&lt;b&gt;%1$.1f&lt;/b&gt; days</string>
<string name="stats_overview_hours">&lt;b&gt;%1$.1f&lt;/b&gt; hours</string>
<string name="stats_overview_hours">&late;p&kit;%1$.1p&late;/p&kit; மணி</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahaa... this is an actual issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, this will be a test of the git-push-only case
I'll root around upstream and resync, I'm watching this and babysitting as YOLO-penance / only way to work on these workflows

Copy link
Member

@david-allison david-allison Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: https://crowdin.com/editor/ankidroid/8169/en-gu?view=comfortable&filter=basic&value=0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the two obvious errors corrected upstream (you and lukstbit beat me to it) - I'm going to try a resync right now.
There is a possibility I will hit a "rebuild cooldown" API limit but I haven't tested that in a while and the last time I pushed it inside 45mins it seemed to work. Perhaps with new v2 crowdin API we are not limited on rebuild cooldown and I'd like to know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 mins I believe

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... this doesn't seem to have updated, but the action passed

@mikehardy mikehardy mentioned this pull request Sep 30, 2024
Closed
@mikehardy mikehardy self-assigned this Sep 30, 2024
@mikehardy
Copy link
Member

Looks like we may still have a "build the translations" API cooldown in place from crowdin as the build did not seem to have the updated contents yet.

But the checks ran at least

Re-run translations sync at (/me checks watch) approximately 9am GMT-5 (that is, 29mins from now)

@mikehardy
Copy link
Member

These new deep-links really are nice...

/home/runner/work/Anki-Android/Anki-Android/AnkiDroid/src/main/res/values-ml/03-dialogs.xml:102: Error: should use unicode '&#8230;' instead of three dots for ellipsis; https://crowdin.com/editor/ankidroid/7303/en-mlin#q=dialog_processing [TranslationTypo from com.ichi2.anki:lint-rules]
    <string name="dialog_processing">പ്രോസസ്സ് ചെയ്യുന്നു...</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Already fixed upstream. Next resync at 9:45a my time... ⏳

@david-allison
Copy link
Member

Could do with a /n I think, but much better!

mikehardy
mikehardy approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

investigated + fixed things upstream, looks good here

@mikehardy mikehardy added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 78674c6 Sep 30, 2024
20 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Hi there @mikehardy-machineaccount! This is the OpenCollective Notice for PRs merged from 2024-09-01 through 2024-09-30

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@david-allison david-allison david-allison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19 release
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehardy-machineaccount @mikehardy @david-allison